initial patch to cause scuttle to work with PHP 8.2
PHP broke a number of syntactical things that were key parts of
scuttle.
- changed the way that objects are initialized to use the "new
Class()" syntax and replace the ClassName functions with __construct.
- add conditional isset() checks to set variables to null before they
are used (esp. in templates)
- rework the ServiceFactory so they are called different and have
access to the database material
- replace deprecated builtins like call_user_func_array() and
create_function()
- handle the explosion of urls a little more gracefully so we don't
have reply on access missing items of arrays.
- search.inc.php relies on a bunch of variables that aren't set
anywhere in the code. I've removed a bunch of stuff from to quite
things but there might be something I'm missing here.
I reran gettext to extract strings. Although this designed to fix the fact that
I changed the 2 week cookie issue, there were a number of strings that have
changed so this ends up being a broader update.
Also rebuild po files and mo files. Translations are now out of date, but
honestly they were before in anycase.
improve the perfromance of the javascript autocomplete lookup
This was performing poorly on large lists. The delay can be set down
very low because the list is stored entirely in memory. The current code
only does the lookup when there are >2 characters typed in for a
particular tag.
Bart Lantz [Wed, 11 Jan 2012 05:13:23 +0000 (22:13 -0700)]
Changed the popup bookmark page to focus on tags field instead of address.
The focus was being directed to the address bar, which I never change. So I
changed it to focus on the tags field as that is the only thing I ever change
when creating a new bookmark.
Bart Lantz [Sat, 17 Dec 2011 19:27:50 +0000 (12:27 -0700)]
Added original date and updated date to bookmark output if different.
If bModified is different from bDatetime, the bookmark is ordered by modified
time from a previous commit, this commit prints both the modified date as well
as the original date if they are different, to avoid confusion.
Bart Lantz [Sat, 17 Dec 2011 02:01:02 +0000 (19:01 -0700)]
Added ability to set default ordering of bookmarks to modified date
This allows you to set default bookmark ordering to be last modified
date, so if you bookmark a URL and it is already bookmarked and you
save it again, then it will appear with most recent bookmarks, instead
of three years ago, for instance. Set this option in config.inc.php.
Bart Lantz [Wed, 11 Jan 2012 05:13:23 +0000 (22:13 -0700)]
Changed the popup bookmark page to focus on tags field instead of address.
The focus was being directed to the address bar, which I never change. So I
changed it to focus on the tags field as that is the only thing I ever change
when creating a new bookmark.
Bart Lantz [Sat, 17 Dec 2011 19:27:50 +0000 (12:27 -0700)]
Added original date and updated date to bookmark output if different.
If bModified is different from bDatetime, the bookmark is ordered by modified
time from a previous commit, this commit prints both the modified date as well
as the original date if they are different, to avoid confusion.
Bart Lantz [Sat, 17 Dec 2011 02:01:02 +0000 (19:01 -0700)]
Added ability to set default ordering of bookmarks to modified date
This allows you to set default bookmark ordering to be last modified
date, so if you bookmark a URL and it is already bookmarked and you
save it again, then it will appear with most recent bookmarks, instead
of three years ago, for instance. Set this option in config.inc.php.
The patch adds a count of the total number of bookmarks that would be
displayed if there were not a per-page limit for the current page. It is
added in parentheses to the subheader on each page or not shown at all
if the variable is not defined for the page.
The default maximum description in Delicious was raised to 1000
characters instead of 255 several years ago. The current setting in
Scuttle makes it impossible for users to import data from their
Delicious account into Scuttle.
When the limit is increased, the old text-box was a bit too small. This
increases it (in line with what Delicious did when they made the
change).
In this patch, tables.sql is updated, but existing installations will
need to alter their database table my hand. In the absense of a system
for migrations, this seems to be able the best we can do.
The default maximum description in Delicious was raised to 1000
characters instead of 255 several years ago. The current setting in
Scuttle makes it impossible for users to import data from their
Delicious account into Scuttle.
When the limit is increased, the old text-box was a bit too small. This
increases it (in line with what Delicious did when they made the
change).
In this patch, tables.sql is updated, but existing installations will
need to alter their database table my hand. In the absense of a system
for migrations, this seems to be able the best we can do.
In my system, with JQuery 1.5, the previous two commits caused *every*
link to load the Flash MP3 mplayer, even though none of these were
playable. This patch fixes that issue.
The issue, as far as I can tell, seems to be due to a change in the
version of JQuery. But I have only looked close enough to fix the bug.
added Thomas Niepraschk's tag autocomplete feature
The work in this patch is taken from the following GH repository:
https://github.com/niepi/scuttle-autocomplete
The work is Copyright (c) Thomas Niepraschk 2011.
Niepraschk's work is not done as a branch to the scuttle git repository,
includes a series of unrelated changes, and involves a few mistakes. In
this branch, I've provided a clean-up of his work but very little of my
own.
I have made the following change over what Thomas did in his repository:
- Reverted the move of config.inc.php from config.inc.php.example
- Changed the script code to not include simple load JQuery from
googleapis.com (introducing some privacy issues) but to load it from
the copies that Thomas included in the repository instead.
- I have also removed from the history several extra files including the
full dump of his database (!) which he them removed in a subsequent
commit.
All credit goes to Thomas Niepraschk for his hard work to build the
functionality. I use it and love it!
Marcus Campbell [Tue, 28 Dec 2010 07:07:14 +0000 (23:07 -0800)]
- Updated default filetypes used for system tags
- Added support for RSS media enclosures
- Restricted registration fields to match DB limits
- Updated debug mode activation
- Updated form style
- Minor code style updates
Signed-off-by: Marcus Campbell <marcus.campbell@gmail.com>
Marcus Campbell [Tue, 21 Dec 2010 08:47:47 +0000 (00:47 -0800)]
- Enforce minimum elapsed time on registration form
- Removed redirection after save
- Show most recent page of results on index, rather than most recent day
- Minor code style updates
- Shameless self-aggrandising
Signed-off-by: Marcus Campbell <marcus.campbell@gmail.com>
Marcus Campbell [Sat, 18 Dec 2010 06:43:48 +0000 (22:43 -0800)]
- Allow blacklisting and whitelisting of e-mail addresses used for new user accounts
- Added hash to the registration form to prevent CRSF
- Added password confirmation to registration form
- Update jQuery to 1.4.4
Signed-off-by: Marcus Campbell <marcus.campbell@gmail.com>
Marcus Campbell [Sun, 13 Jul 2008 01:09:50 +0000 (01:09 +0000)]
* Fixed REG_BADRPT error in isValidEmail() that prevented registration
* Merged cookie fix from trunk
* Set body background to white
* Removed poor seed from _randompassword()
* Minor fix to updateBookmark()
Marcus Campbell [Sat, 9 Dec 2006 06:13:28 +0000 (06:13 +0000)]
Merge trunk fix for [ 1480341 ] Timezone Bug
Merge trunk fix for [ 1493870 ] Problem with required files in gettext.inc
Merge trunk fix for [ 1495135 ] Missing a closing parenthesis in ajaxGetTitle.php
Merged trunk changes for .htaccess file
projects / scuttle / log