]> projects.mako.cc - scuttle/commit
initial patch to cause scuttle to work with PHP 8.2
authorBenjamin Mako Hill <mako@atdot.cc>
Fri, 21 Jun 2024 06:51:39 +0000 (16:51 +1000)
committerBenjamin Mako Hill <mako@atdot.cc>
Fri, 21 Jun 2024 09:22:09 +0000 (19:22 +1000)
commit91d3a96bb7741ba92d2d3d7a7dc7d18e0d79688f
treea77ec92f83d0138b26d3edb99786452e41c4ad0f
parent4aa12354e396c6f1551076d515e0e7a81bf54266
initial patch to cause scuttle to work with PHP 8.2

PHP broke a number of syntactical things that were key parts of
scuttle.

- changed the way that objects are initialized to use the "new
  Class()" syntax and replace the ClassName functions with __construct.

- add conditional isset() checks to set variables to null before they
  are used (esp. in templates)

- rework the ServiceFactory so they are called different and have
  access to the database material

- replace deprecated builtins like call_user_func_array() and
  create_function()

- handle the explosion of urls a little more gracefully so we don't
  have reply on access missing items of arrays.

- search.inc.php relies on a bunch of variables that aren't set
  anywhere in the code. I've removed a bunch of stuff from to quite
  things but there might be something I'm missing here.
43 files changed:
about.php
ajaxDelete.php
ajaxIsAvailable.php
alltags.php
bookmarks.php
edit.php
history.php
import.php
importNetscape.php
index.php
login.php
password.php
populartags.php
profile.php
register.php
rss.php
search.inc.php
search.php
services/bookmarkservice.php
services/servicefactory.php
services/tagservice.php
services/templateservice.php
services/userservice.php
tagdelete.php
tagrename.php
tags.php
templates/bookmarks.tpl.php
templates/dynamictags.inc.php
templates/editbookmark.tpl.php
templates/profile.tpl.php
templates/sidebar.block.common.php
templates/sidebar.block.popular.php
templates/sidebar.block.profile.php
templates/sidebar.block.recent.php
templates/sidebar.block.related.php
templates/sidebar.block.tagactions.php
templates/sidebar.block.watchlist.php
templates/sidebar.block.watchstatus.php
templates/sidebar.tpl.php
templates/toolbar.inc.php
templates/top.inc.php
watch.php
watchlist.php

Benjamin Mako Hill || Want to submit a patch?