updated readme with information on a series of bugs I know exist

[scuttle] / bookmarks.php

diff --git a/bookmarks.php b/bookmarks.php
index cc5eba4582286f20b9acbb220f957db910522d8e..cbedbfdf7a35d81a537cabe7b9dd95dbc6b928f6 100644 (file)
--- a/bookmarks.php
+++ b/bookmarks.php
@@ -1,7 +1,6 @@
 <?php
 /***************************************************************************
 <?php
 /***************************************************************************

-Copyright (C) 2004 - 2006 Scuttle project
-http://sourceforge.net/projects/scuttle/
+Copyright (c) 2004 - 2010 Marcus Campbell

 http://scuttle.org/
 
 This program is free software; you can redistribute it and/or modify
 http://scuttle.org/
 
 This program is free software; you can redistribute it and/or modify


@@ -19,12 +18,13 @@ along with this program; if not, write to the Free Software
 Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
 ***************************************************************************/
 
 Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
 ***************************************************************************/
 

-require_once('header.inc.php');
+require_once 'header.inc.php';

 
 

-$bookmarkservice =& ServiceFactory::getServiceInstance('BookmarkService');
-$templateservice =& ServiceFactory::getServiceInstance('TemplateService');
-$userservice =& ServiceFactory::getServiceInstance('UserService');
-$cacheservice =& ServiceFactory::getServiceInstance('CacheService');
+$sf = new ServiceFactory();
+$bookmarkservice =& $sf->getServiceInstance('BookmarkService');
+$templateservice =& $sf->getServiceInstance('TemplateService');
+$userservice     =& $sf->getServiceInstance('UserService');
+$cacheservice    =& $sf->getServiceInstance('CacheService');

 
 $tplVars = array();
 
 
 $tplVars = array();
 


@@ -34,6 +34,7 @@ if (isset($_GET['action']) && ($_GET['action'] == "add") && !$userservice->isLog
     exit();
 }
 
     exit();
 }
 

+# it would probably be better to not supress the errors here

 @list($url, $user, $cat) = isset($_SERVER['PATH_INFO']) ? explode('/', $_SERVER['PATH_INFO']) : NULL;
 
 $loggedon = false;
 @list($url, $user, $cat) = isset($_SERVER['PATH_INFO']) ? explode('/', $_SERVER['PATH_INFO']) : NULL;
 
 $loggedon = false;


@@ -96,11 +97,13 @@ if ($loggedon && isset($_POST['submitted'])) {
         $templatename = 'editbookmark.tpl';
     } else {
         $address = trim($_POST['address']);
         $templatename = 'editbookmark.tpl';
     } else {
         $address = trim($_POST['address']);

+

         // If the bookmark exists already, edit the original
         if ($bookmarkservice->bookmarkExists($address, $currentUserID)) {
             $bookmark =& $bookmarkservice->getBookmarkByAddress($address);
             header('Location: '. createURL('edit', $bookmark['bId']));
             exit();
         // If the bookmark exists already, edit the original
         if ($bookmarkservice->bookmarkExists($address, $currentUserID)) {
             $bookmark =& $bookmarkservice->getBookmarkByAddress($address);
             header('Location: '. createURL('edit', $bookmark['bId']));
             exit();

+

         // If it's new, save it
         } else {
             $title = trim($_POST['title']);
         // If it's new, save it
         } else {
             $title = trim($_POST['title']);


@@ -113,11 +116,6 @@ if ($loggedon && isset($_POST['submitted'])) {
                     $tplVars['msg'] = '<script type="text/javascript">window.close();</script>';
                 } else {
                     $tplVars['msg'] = T_('Bookmark saved');
                     $tplVars['msg'] = '<script type="text/javascript">window.close();</script>';
                 } else {
                     $tplVars['msg'] = T_('Bookmark saved');

-                    // Redirection option
-                    if ($GLOBALS['useredir']) {
-                        $address = $GLOBALS['url_redir'] . $address;
-                    }
-                    header('Location: '. $address);

                 }
             } else {
                 $tplVars['error'] = T_('There was an error saving your bookmark. Please try again or contact the administrator.');
                 }
             } else {
                 $tplVars['error'] = T_('There was an error saving your bookmark. Please try again or contact the administrator.');


@@ -151,11 +149,16 @@ if ($templatename == 'editbookmark.tpl') {
             );
             $tplVars['tags'] = $_POST['tags'];
         } else {
             );
             $tplVars['tags'] = $_POST['tags'];
         } else {

+            if (isset($_GET['tags'])) {
+                $raw_tags = $_GET['tags'];
+            } else {
+                $raw_tags = NULL;
+            }

             $tplVars['row'] = array(
                 'bTitle' => stripslashes($_GET['title']),
                 'bAddress' => stripslashes($_GET['address']),
                 'bDescription' => stripslashes($_GET['description']),
             $tplVars['row'] = array(
                 'bTitle' => stripslashes($_GET['title']),
                 'bAddress' => stripslashes($_GET['address']),
                 'bDescription' => stripslashes($_GET['description']),

-                'tags' => ($_GET['tags'] ? explode(',', stripslashes($_GET['tags'])) : array())
+                'tags' => ($raw_tags ? explode(',', stripslashes($raw_tags)) : array())

             );
         }
         $title = T_('Add a Bookmark');
             );
         }
         $title = T_('Add a Bookmark');


@@ -206,7 +209,7 @@ if ($templatename == 'editbookmark.tpl') {
     $tplVars['start'] = $start;
     $tplVars['bookmarkCount'] = $start + 1;
     
     $tplVars['start'] = $start;
     $tplVars['bookmarkCount'] = $start + 1;
     

-    $bookmarks =& $bookmarkservice->getBookmarks($start, $perpage, $userid, $cat, $terms, getSortOrder());
+    $bookmarks =& $bookmarkservice->getBookmarks($start, $perpage, $userid, $cat, '', getSortOrder());

     $tplVars['total'] = $bookmarks['total'];
     $tplVars['bookmarks'] =& $bookmarks['bookmarks'];
     $tplVars['cat_url'] = createURL('bookmarks', '%s/%s');
     $tplVars['total'] = $bookmarks['total'];
     $tplVars['bookmarks'] =& $bookmarks['bookmarks'];
     $tplVars['cat_url'] = createURL('bookmarks', '%s/%s');


@@ -225,4 +228,3 @@ if ($usecache && $endcache) {
     // Cache output if existing copy has expired
     $cacheservice->End($hash);
 }
     // Cache output if existing copy has expired
     $cacheservice->End($hash);
 }

-?>