Fix error when getting a quickvote result of nonexistent ident

[selectricity] / app / controllers / graph_controller.rb

diff --git a/app/controllers/graph_controller.rb b/app/controllers/graph_controller.rb
index 4f33ac3a3f7b02d212a7362ca9b26f10d0e22f3a..1bde09e1c4dae465b1221c1321e1ae8a5393db81 100644 (file)
--- a/app/controllers/graph_controller.rb
+++ b/app/controllers/graph_controller.rb
@@ -1,50 +1,156 @@
 require 'date'
 require 'date'

-class GraphController < ApplicationController
+class GraphController < ApplicationController  
+  class GruffGraff
+  
+    def initialize(options)
+      size = "700x400"
+      @graph = options[:graph_type].new(size)
+
+      @graph.theme = { :colors => ['#000000', '#00FFFF', '#FFCC00', '#990033'],
+                       :background_colors => ['#74ce00', '#ffffff'] }
+      @graph.font = File.expand_path('/usr/X11R6/lib/X11/fonts/TTF/Vera.ttf',
+                                   RAILS_ROOT)
+      
+      # fill in the data with the optional data name
+      #Check to see if multiple datasets, if so, fill them all!
+      if options[:data].is_a?(Hash) 
+        options[:data].each_pair do |name, array|
+          @graph.data( name, array)
+        end
+      #if each dataset nameless, will have only multiple arrays    
+      elsif options[:data].size > 1 && options[:data].all?  {|i| i.is_a?(Array)}
+        options[:data].each do |array|
+          @graph.data( options.fetch(:data_name, "Data"), array)
+        end
+      else #one dimensional array, just pass it in
+      @graph.data( options.fetch(:data_name, "Data"), options[:data] )
+      end
+      
+      # set the labels or create an empty hash
+      @graph.labels = options[:interval_labels] \
+        if options.has_key?(:interval_labels) and \
+           options[:interval_labels].class == Hash
+      @graph.x_axis_label = options[:x_axis_label] \
+        if options.has_key?(:x_axis_label)
+      @graph.y_axis_label = options[:y_axis_label] \
+        if options.has_key?(:y_axis_label)
+      @graph.title = options[:title] if options.has_key?(:title)
+      
+      @graph.minimum_value = 0.0
+
+    end
+
+    def output
+      return([@graph.to_blob, {:disposition => 'inline', :type => 'image/png'}])
+    end
+
+  end
+

   # produce a graph of votes per day during an election
   def votes_per_day
     @election = Election.find(params[:id])
     data, labels = get_votes_per_day_data(@election)
     
   # produce a graph of votes per day during an election
   def votes_per_day
     @election = Election.find(params[:id])
     data, labels = get_votes_per_day_data(@election)
     

-    line = Gruff::Line.new("700x400")
-    line.theme = { :background_colors => ['#73BF26', '#ffffff'] }
-    line.title = "Voters Per Day"
-    line.font = File.expand_path('/usr/X11R6/lib/X11/fonts/TTF/Vera.ttf',
-                                 RAILS_ROOT)
-
-    line.data("#{@election.name}", data )
-    line.labels = labels
-
-    line.x_axis_label = "Date"
-    line.y_axis_label = "Number of Votes"
-    line.minimum_value = 0.0
-
-    line.draw
-    send_data(line.to_blob, :disposition => 'inline', :type => 'image/png')
+    graph = GruffGraff.new( :graph_type => Gruff::Line,
+                            :data_name => @election.name,
+                            :data => data,
+                            :interval_labels => labels,
+                            :title => "Voters Per Day",
+                            :x_axis_label => "Data",
+                            :y_axis_label =>"Number of Votes")
+    send_data(*graph.output)

   end
   end

- 
+  
+  #will place votes in a fixed number of intervals, and shows votes over time

   def votes_per_interval
     @election = Election.find(params[:id])
   def votes_per_interval
     @election = Election.find(params[:id])

-    data, labels = get_votes_per_interval_data(@election)
-    
-    line = Gruff::Line.new("700x400")
-    line.theme = { :background_colors => ['#73BF26', '#ffffff'] }
-    line.title = "Voters Over Time"
-    line.font = File.expand_path('/usr/X11R6/lib/X11/fonts/TTF/Vera.ttf',
-                               RAILS_ROOT)
-    
-    line.data("#{@election.name}", data )
-    line.labels = labels
-    
-    line.x_axis_label = "Intervals"
-    line.y_axis_label = "Number of Votes"
-    line.minimum_value = 0.0
-                               
-    line.draw
-    send_data(line.to_blob, :disposition => 'inline', :type => 'image/png')  
+    data, labels, scale = get_votes_per_interval_data(@election)
+    
+    graph = GruffGraff.new( :graph_type => Gruff::Line,
+                            :data_name => @election.name,
+                            :data => data,
+                            :interval_labels => labels,
+                            :title => "Voters Over Time",
+                            :x_axis_label => scale,
+                            :y_axis_label => "Number of Votes")
+    send_data(*graph.output)
+  end
+
+  def borda_bar
+    @election = Election.find(params[:id])
+    @election.results unless @election.borda_result
+    data, labels = get_borda_points(@election.borda_result)
+    
+    graph = GruffGraff.new( :graph_type => Gruff::Bar,
+                            :data_name => @election.name,
+                            :data => data,
+                            :interval_labels => labels,
+                            :title => "Points Per Candidate",
+                            :y_axis_label => "Points",
+                            :x_axis_label => "Candidate")
+    send_data(*graph.output)
+  end
+  #Acording to Tufte, small, concomparitive, highly labeled data sets usually
+  # belong in tables. The following is a bar graph...but would it be better
+  #as a table?
+  def choices_positions
+    
+    @election = Election.find(params[:id])
+    pref_tally = make_preference_tally(@election)
+    
+    fulldata, labels = get_positions_info(@election)
+    legend = Hash.new
+    
+    @election.candidates.each_with_index do |candidate, index|
+      legend[candidate.name] = fulldata[index]
+    end
+    
+    graph = GruffGraff.new( :graph_type => Gruff::Bar,
+                            :data => legend,
+                            :interval_labels => labels,
+                            :title => "Times Voted in Each Position",
+                            :y_axis_label => "Number of Times Ranked",
+                            :x_axis_label => "Rank")
+    send_data(*graph.output) 

   end
   end

- 
+  

  private 
  private 

- 
+  def get_positions_info(election)
+    buckets = Hash.new
+    buckets2= Hash.new
+    rank_labels = Hash.new
+    
+    election.candidates.each do |candidate|
+      buckets[candidate.id] = []
+      buckets2[candidate.id] = []
+    end
+    
+    #attach the ranking to the candidate's array to which is belongs
+    election.votes.each do |vote|
+      vote.rankings.each do |ranking|
+        buckets[ranking.candidate_id] << ranking.rank
+      end
+    end
+    
+    #count how many times each candidate has been ranked at a certain level
+    buckets.each_pair do |id, array|
+      (1..election.candidates.size).each do |i|
+        buckets2[id] << (array.find_all {|rank| rank == i}).size
+      end
+    end
+    
+    #sort by amount of 1st place votes
+    sorted_data = buckets2.values.sort {|a,b| b[0] <=> a[0]}
+    
+    election.votes.each do |vote|
+      vote.rankings.size.times do |i|
+        rank_labels[i] = (i+1).to_s
+      end
+    end
+    
+    return sorted_data, rank_labels   
+  end
+   

   # generate the data and labels for each graph
   def get_votes_per_day_data(election)
     voter_days = Array.new
   # generate the data and labels for each graph
   def get_votes_per_day_data(election)
     voter_days = Array.new


@@ -64,7 +170,8 @@ class GraphController < ApplicationController
     
     # Now I need to create an array with all the times votes were made
     election.votes.each do |vote|
     
     # Now I need to create an array with all the times votes were made
     election.votes.each do |vote|

-        voter_days << Date.parse(vote.time.to_s)
+      next unless vote.time
+      voter_days << Date.parse(vote.time.to_s)

     end
     voter_days.sort!
     
     end
     voter_days.sort!
     


@@ -93,6 +200,7 @@ class GraphController < ApplicationController
     labels_hash = Hash.new
     buckets = Hash.new
     total_per_interval = Array.new
     labels_hash = Hash.new
     buckets = Hash.new
     total_per_interval = Array.new

+    interval_type = ""

     
     starttime = election.startdate
     timedelta = Time.now - starttime
     
     starttime = election.startdate
     timedelta = Time.now - starttime


@@ -101,14 +209,15 @@ class GraphController < ApplicationController
     
     # Make a hash, buckets, indexed by time intervals and containing empty arrays
     # The time object must come first in addition! 
     
     # Make a hash, buckets, indexed by time intervals and containing empty arrays
     # The time object must come first in addition! 

-    # i would start at 0, i+1 goes from 0 up till numcols
+    # i would start at 0, i+1 goes from 1 up till numcols

     numcols.times {|i| buckets[starttime + ((i+1)*interval_length)] = []}
      
     # Put votes into bucket according to the time interval to which they belong,
     # referenced by their key
     numcols.times {|i| buckets[starttime + ((i+1)*interval_length)] = []}
      
     # Put votes into bucket according to the time interval to which they belong,
     # referenced by their key

-    # Will build a graph over time, as each successive interval wil lhave more
+    # Will build a graph over time, as each successive interval will have more

     # vote objects  
     election.votes.each do |vote|
     # vote objects  
     election.votes.each do |vote|

+      next unless vote.time

       buckets.keys.sort.each do |inter|
         if vote.time < inter
           buckets[inter] << vote
       buckets.keys.sort.each do |inter|
         if vote.time < inter
           buckets[inter] << vote


@@ -124,18 +233,50 @@ class GraphController < ApplicationController
       labels_hash[0] = starttime.min.to_s
       labels_hash[(numcols/2)-1] = (starttime + (timedelta/2)).min.to_s
       labels_hash[numcols-1] = Time.now.min.to_s
       labels_hash[0] = starttime.min.to_s
       labels_hash[(numcols/2)-1] = (starttime + (timedelta/2)).min.to_s
       labels_hash[numcols-1] = Time.now.min.to_s

+      interval_type = "Minute of the Hour"

     elsif timedelta < 2.days #more than 2 hours means use hours for labels
       labels_hash[0] = starttime.hour.to_s
       labels_hash[(numcols/2)-1] = (starttime + (timedelta/2)).hour.to_s
       labels_hash[numcols-1] = Time.now.hour.to_s
     elsif timedelta < 2.days #more than 2 hours means use hours for labels
       labels_hash[0] = starttime.hour.to_s
       labels_hash[(numcols/2)-1] = (starttime + (timedelta/2)).hour.to_s
       labels_hash[numcols-1] = Time.now.hour.to_s

+      interval_type = "Hour of the Day on 24 hour scale"

     else #more than 2 days means use dates for labels
       labels_hash[0] = (Date.parse(starttime.to_s)).to_s
     else #more than 2 days means use dates for labels
       labels_hash[0] = (Date.parse(starttime.to_s)).to_s

-      labels_hash[(numcols/2)-1] = (Date.parse(starttime + (timedelta/2))).to_s
+      labels_hash[(numcols/2)-1] = (Date.parse((starttime + (timedelta/2)).to_s)).to_s

       labels_hash[numcols-1] = (Date.today).to_s
       labels_hash[numcols-1] = (Date.today).to_s

+      interval_type = "The Date"

     end
     
     # Make sure to return an array for data and hash for labels
     end
     
     # Make sure to return an array for data and hash for labels

-    return total_per_interval, labels_hash   
+    return total_per_interval, labels_hash, interval_type   
+  end
+  
+  def get_borda_points(result)
+    points = Array.new
+    labels = Hash.new
+
+    #Populate points with an sorted array from election.votes hash
+    #biggest to smallest will go from left to right
+    points = result.points.sort do |a, b|
+      b[1] <=> a[1]
+    end.collect {|i| i[1]}
+
+    #make the labels  
+    result.ranked_candidates.each_with_index do |candidate, index|
+      labels[index] = Candidate.find(candidate).name
+    end
+
+    return points, labels
+  end
+
+  #most vote result objects require an array of vote arrays, which this will make
+  def make_preference_tally(election)
+    preference_tally = Array.new
+    @election.voters.each do |voter|
+      next unless voter.voted?
+      preference_tally << voter.vote.rankings.sort.collect \
+        { |ranking| ranking.candidate.id }
+    end
+  return preference_tally

   end
 
 end
   end
 
 end