fix security issue

[selectricity] / app / models / election.rb

diff --git a/app/models/election.rb b/app/models/election.rb
index 0860a426ff137d84dc9184ac322725aec05553cf..7c15dcfcd785298c1e524702801d69fdfd4f3147 100644 (file)
--- a/app/models/election.rb
+++ b/app/models/election.rb
@@ -1,18 +1,63 @@
+# Selectricity: Voting Machinery for the Masses
+# Copyright (C) 2007, 2008 Benjamin Mako Hill <mako@atdot.cc>
+# Copyright (C) 2007 Massachusetts Institute of Technology
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License as
+# published by the Free Software Foundation, either version 3 of the
+# License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+# Affero General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public
+# License along with this program.  If not, see
+# <http://www.gnu.org/licenses/>.
+

 class Election < ActiveRecord::Base
   has_many :candidates
   has_many :voters
   has_many :votes
   belongs_to :user
   validates_presence_of :name, :description
 class Election < ActiveRecord::Base
   has_many :candidates
   has_many :voters
   has_many :votes
   belongs_to :user
   validates_presence_of :name, :description

-
+  
+  #validate that method is one of the listed election types
+  
+  attr_reader :plurality_result
+  attr_reader :approval_result
+  attr_reader :condorcet_result
+  attr_reader :ssd_result
+  attr_reader :borda_result
+  

   require 'date'
   require 'date'

+  
+  def initialize(params={})
+    super
+    self.enddate = read_attribute( :enddate ) || \
+                   Time.now + 30.days - 1.second
+  end
+
+  def other_methods
+    if election_method
+      @other_methods = ELECTION_TYPES.keys.reject {|i| i == election_method}
+    else
+      @other_methods = nil
+    end
+    @other_methods
+  end

 
   def startdate
 
   def startdate

-    read_attribute( :startdate ) || DateTime.now
+    read_attribute( :startdate ) || Time.now

   end
 
   end
 

-  def enddate
-    read_attribute( :enddate ) || DateTime.now + 14
+  def votes
+    votes = Array.new
+    self.voters.each do |voter|
+      votes << voter.vote
+    end
+    return votes

   end
 
   def destroy
   end
 
   def destroy


@@ -24,12 +69,11 @@ class Election < ActiveRecord::Base
 
   def start_blockers
     reasons = []
 
   def start_blockers
     reasons = []

-    

     if self.candidates.length <= 1
       reasons << "You must have at least two candidates."
     end
     
     if self.candidates.length <= 1
       reasons << "You must have at least two candidates."
     end
     

-    if self.voters.length <= 1
+    if self.voters.length <= 1 and self.authenticated?

       reasons << "You must have at least two voters."
     end
 
       reasons << "You must have at least two voters."
     end
 


@@ -38,10 +82,95 @@ class Election < ActiveRecord::Base
 
   def activate!
     self.active = 1
 
   def activate!
     self.active = 1

+    self.save!

   end
   
   def quickvote?
   end
   
   def quickvote?

-    quickvote.to_i == 1
+    self.class == QuickVote
+  end
+
+  def active?
+    active == 1
+  end 
+
+  def done?
+    active == 2
+  end
+
+  def authenticated?
+    authenticated
+  end
+  
+  def shortdesc
+    shortdesc = description.split(/\n/)[0]
+  end
+
+  def longdesc
+    longdesc = description.split(/\n/)[1..-1].join("")
+    longdesc.length > 0 ? longdesc : nil 
+  end
+  
+  #Calculate results if not in memcache
+  def results
+    # Assignment is intentional
+    if Cache and c = Cache.get("election_results:#{id}:#{self.votes.length}")
+      @plurality_result = c['plurality']
+      @approval_result = c['approval']
+      @condorcet_result = c['condorcet']
+      @ssd_result = c['ssd']
+      @borda_result = c['borda']
+      return c
+    elsif Cache
+      # memcache is available, but missed.
+      results = self.results!
+      Cache.set("election_results:#{id}:#{self.votes.length}", results)
+      return results
+    else
+      return self.results!
+    end

   end
 
   end
 

+  #Always Calculate Election Results
+  def results!
+    # initalize the tallies to empty arrays
+    preference_tally = Array.new
+    plurality_tally = Array.new
+    approval_tally = Array.new
+
+    self.voters.each do |voter|
+      # skip if the voter has not voted or has an unconfirmed vote
+      next unless voter.voted?
+
+      plurality_tally << voter.vote.rankings.sort[0].candidate_id
+      approval_tally << voter.vote.rankings.sort[0..1].collect \
+        { |ranking| ranking.candidate_id }
+      preference_tally << voter.vote.rankings.sort.collect \
+        { |ranking| ranking.candidate_id }
+    end
+    
+    @plurality_result = PluralityVote.new(plurality_tally).result
+    @approval_result = ApprovalVote.new(approval_tally).result
+    @condorcet_result = PureCondorcetVote.new(preference_tally).result
+    @ssd_result = CloneproofSSDVote.new(preference_tally).result
+    @borda_result = BordaVote.new(preference_tally).result
+    
+    { 'plurality' => @plurality_result,
+      'approval' => @approval_result,
+      'condorcet' => @condorcet_result,
+      'ssd' => @ssd_result,
+      'borda' => @borda_result }
+    end
+  
+  def names_by_id
+    names = Hash.new
+    
+    competitors = self.candidates.sort.collect {|candidate| candidate.id}
+    competitors.each do |candidate|
+      names[candidate] = Candidate.find(candidate).name
+    end
+    
+    names
+  end

 end
 end

+
+