fixed up a series of things in prepration for the stress test on friday

[selectricity] / app / models / election.rb

diff --git a/app/models/election.rb b/app/models/election.rb
index d76c13f633cd7ddb7b48ca560deb60d54f266d4a..4ce571a468c4aa91a39fd6696e7a76161e706afd 100644 (file)
--- a/app/models/election.rb
+++ b/app/models/election.rb
@@ -1,31 +1,47 @@
+# Selectricity: Voting Machinery for the Masses
+# Copyright (C) 2007, 2008 Benjamin Mako Hill <mako@atdot.cc>
+# Copyright (C) 2007 Massachusetts Institute of Technology
+#
+# This program is free software. Please see the COPYING file for
+# details.
+
 class Election < ActiveRecord::Base
   has_many :candidates
   has_many :voters
   has_many :votes
   belongs_to :user
   validates_presence_of :name, :description
-  
+
+  # enforce constraints associated with dependencies (i.e., a kiosk
+  # election can't also be unauthenticated)
+  before_save :enforce_constraints
+
+  #validate that method is one of the listed election types
   attr_reader :plurality_result
   attr_reader :approval_result
   attr_reader :condorcet_result
   attr_reader :ssd_result
   attr_reader :borda_result
-
+  
   require 'date'
-
-  def startdate
-    read_attribute( :startdate ) || Time.now
+ 
+  def initialize(params={})
+    super
+    self.enddate = read_attribute( :enddate ) || \
+                   Time.now + 30.days - 1.second
   end
-  
-  def enddate
-    date = read_attribute( :enddate ) || Time.now + 14
-    date - 1.second
+
+  def other_methods
+    if election_method
+      @other_methods = ELECTION_TYPES.keys.reject {|i| i == election_method}
+    else
+      @other_methods = nil
+    end
+    @other_methods
   end
 
-  def enddate=(date)
-    date += 1.day
-    date = Time.gm(*date)
-    super(date)
+  def startdate
+    read_attribute( :startdate ) || Time.now
   end
 
   def votes
@@ -45,12 +61,11 @@ class Election < ActiveRecord::Base
 
   def start_blockers
     reasons = []
-    
     if self.candidates.length <= 1
       reasons << "You must have at least two candidates."
     end
     
-    if self.voters.length <= 1
+    if self.voters.length <= 1 and self.authenticated?
       reasons << "You must have at least two voters."
     end
 
@@ -59,11 +74,11 @@ class Election < ActiveRecord::Base
 
   def activate!
     self.active = 1
-    self.save!
+    self.save
   end
   
   def quickvote?
-    self.class == 'QuickVote'
+    self.class == QuickVote
   end
 
   def active?
@@ -74,6 +89,14 @@ class Election < ActiveRecord::Base
     active == 2
   end
 
+  def authenticated?
+    authenticated
+  end
+
+  def kiosk?
+    kiosk
+  end
+  
   def shortdesc
     shortdesc = description.split(/\n/)[0]
   end
@@ -83,8 +106,28 @@ class Election < ActiveRecord::Base
     longdesc.length > 0 ? longdesc : nil 
   end
   
-  #Calculate Election Results
+  #Calculate results if not in memcache
   def results
+    # Assignment is intentional
+    if Cache and c = Cache.get("election_results:#{id}:#{self.votes.length}")
+      @plurality_result = c['plurality']
+      @approval_result = c['approval']
+      @condorcet_result = c['condorcet']
+      @ssd_result = c['ssd']
+      @borda_result = c['borda']
+      return c
+    elsif Cache
+      # memcache is available, but missed.
+      results = self.results!
+      Cache.set("election_results:#{id}:#{self.votes.length}", results)
+      return results
+    else
+      return self.results!
+    end
+  end
+
+  #Always Calculate Election Results
+  def results!
     # initalize the tallies to empty arrays
     preference_tally = Array.new
     plurality_tally = Array.new
@@ -100,15 +143,19 @@ class Election < ActiveRecord::Base
       preference_tally << voter.vote.rankings.sort.collect \
         { |ranking| ranking.candidate.id }
     end
+    
     @plurality_result = PluralityVote.new(plurality_tally).result
     @approval_result = ApprovalVote.new(approval_tally).result
     @condorcet_result = PureCondorcetVote.new(preference_tally).result
     @ssd_result = CloneproofSSDVote.new(preference_tally).result
     @borda_result = BordaVote.new(preference_tally).result
-    #@runoff_result = InstantRunoffVote.new(preference_tally).result
     
-    nil # to stay consistent
-  end
+    { 'plurality' => @plurality_result,
+      'approval' => @approval_result,
+      'condorcet' => @condorcet_result,
+      'ssd' => @ssd_result,
+      'borda' => @borda_result }
+    end
   
   def names_by_id
     names = Hash.new
@@ -120,7 +167,30 @@ class Election < ActiveRecord::Base
     
     names
   end
-  
+
+  def candidate_hash
+    hash = {}
+    self.candidates.each {|c| hash[c.id] = c}
+    return hash
+  end
+
+ 
+  # TODO now that this code is in here, we should go ahead and remove
+  # date checking from other places in the code
+  def after_find
+    if self.active < 2 and self.enddate < Time.now 
+      self.active = 2
+      self.save
+    end
+  end
+
+  private
+  def enforce_constraints
+    # kiosks can't be authenticated
+    self.authenticated = false if kiosk?
+    return true
+  end
+
 end