Fix full voter addition bug where the regex flunks the trailing \r on middle items...

[selectricity] / app / controllers / election_controller.rb

diff --git a/app/controllers/election_controller.rb b/app/controllers/election_controller.rb
index a0549d40d510fabb9abd71e223a528a29879be48..05a66fff5fef68c273ca0a9c024283a26a0f0a76 100644 (file)
--- a/app/controllers/election_controller.rb
+++ b/app/controllers/election_controller.rb
@@ -1,15 +1,25 @@
 class ElectionController < ApplicationController
 class ElectionController < ApplicationController

-  model :raw_voter_list, :voter, :vote, :candidate
-  layout 'vb'
+  require_dependency "raw_voter_list"
+  require_dependency "voter"
+  require_dependency "vote"
+  require_dependency "candidate"
+  layout 'main'

 
 

-  before_filter :login_required
+  #before_filter :login_required

 
   ## methods for displaying, creating,
   ## and manipulating election overview data
   ####################################################################
 
   def new
 
   ## methods for displaying, creating,
   ## and manipulating election overview data
   ####################################################################
 
   def new

+    redirect_to :action => 'general_information'
+  end
+  
+  def general_information
+    @sidebar_content = render_to_string :partial => 'progress',
+                                        :locals => { :page => 'overview' }

     @election = Election.new
     @election = Election.new

+    render :action => 'general_information'

   end
   
   def create_election
   end
   
   def create_election


@@ -24,7 +34,7 @@ class ElectionController < ApplicationController
       flash[:notice] = 'Election was successfully created.'
       redirect_to :action => 'edit_candidates', :id => @election.id
     else
       flash[:notice] = 'Election was successfully created.'
       redirect_to :action => 'edit_candidates', :id => @election.id
     else

-      render :action => 'new'
+      render :action => 'general_information'

     end
   end
   
     end
   end
   


@@ -48,24 +58,33 @@ class ElectionController < ApplicationController
     end
   end
 
     end
   end
 

-  def destroy
-    election = Election.find(params[:id]).destroy
-    redirect_to :action => 'list'
+  def start_election
+    @election = Election.find(params[:id])
+    @election.voters.each do |voter|
+      voter.vote = Vote.new
+      email = VoterNotify.deliver_votestart(voter)
+      #render(:text => "<pre>" + email.encoded + "</pre>")
+    end
+
+    @election.activate!
+    redirect_to :action => 'show', :id => @election.id

   end
 
   # methods fod display, adding, deleting, and manipulating candidate
   # information for elections
   ####################################################################
   def edit_candidates
   end
 
   # methods fod display, adding, deleting, and manipulating candidate
   # information for elections
   ####################################################################
   def edit_candidates

+    @sidebar_content = render_to_string :partial => 'progress',
+                                        :locals => { :page => 'candidates' }

     @election = Election.find( params[:id] )
   end
 
   def add_candidate
     @election = Election.find(params[:id])
     @candidate = Candidate.new(params[:candidate])
     @election = Election.find( params[:id] )
   end
 
   def add_candidate
     @election = Election.find(params[:id])
     @candidate = Candidate.new(params[:candidate])

-    
+    @election.candidates << @candidate
+

     if @candidate.save
     if @candidate.save

-      @election.candidates << @candidate

       @candidate = Candidate.new
       redirect_to :action => 'edit_candidates', :id => @election.id
     else
       @candidate = Candidate.new
       redirect_to :action => 'edit_candidates', :id => @election.id
     else


@@ -80,13 +99,13 @@ class ElectionController < ApplicationController
 
   def lessinfo_candidate
     @show_details = false
 
   def lessinfo_candidate
     @show_details = false

-    @candidate = Candidate.find( params[:id] )
+    @current_candidate = Candidate.find( params[:id] )

     render :partial => 'candidate_line'
   end
 
   def moreinfo_candidate
     @show_details = true
     render :partial => 'candidate_line'
   end
 
   def moreinfo_candidate
     @show_details = true

-    @candidate = Candidate.find( params[:id] )
+    @current_candidate = Candidate.find( params[:id] )

     render :partial => 'candidate_line'
   end
 
     render :partial => 'candidate_line'
   end
 


@@ -97,20 +116,20 @@ class ElectionController < ApplicationController
 
   def update_candidate
     @candidate = Candidate.find(params[:id])
 
   def update_candidate
     @candidate = Candidate.find(params[:id])

+    @election = @candidate.election

 
     if @candidate.update_attributes(params[:candidate])
 
     if @candidate.update_attributes(params[:candidate])

-      flash[:notice] = 'Candidate information was successfully updated.'
-      redirect_to :action => 'edit_candidates', :id => @candidate.election
+      redirect_to :action => 'edit_candidates', :id => @candidate.election.id

     else
     else

-      render :action => 'edit_candidates'
+      render :action => 'edit_candidate'

     end
   end
 
   def candidate_picture
     candidate = Candidate.find( params[:id] )
     end
   end
 
   def candidate_picture
     candidate = Candidate.find( params[:id] )

-    send_data( candidate.picture_data,
-               :filename => candidate.picture_filename,
-              :type => candidate.picture_type,
+    send_data( candidate.picture.data,
+               :filename => candidate.picture.filename,
+              :type => candidate.picture.filetype,

               :disposition => 'inline' )
   end
 
               :disposition => 'inline' )
   end
 


@@ -118,12 +137,7 @@ class ElectionController < ApplicationController
   ## for a particular election
   ####################################################################
   def new_voters
   ## for a particular election
   ####################################################################
   def new_voters

-    @election = Election.find( params[:id] )
-    if params.has_key?[:raw_voter_list]
-      process_incoming_voters( params[:raw_voter_list] )
-    end
-    @raw_voter_list = RawVoterList.new
-
+    edit_voters

   end
   
   def edit_voters
   end
   
   def edit_voters


@@ -131,7 +145,6 @@ class ElectionController < ApplicationController
     if params.has_key?( :raw_voter_list )
       process_incoming_voters( params[:raw_voter_list] )
     end
     if params.has_key?( :raw_voter_list )
       process_incoming_voters( params[:raw_voter_list] )
     end

-

     @raw_voter_list = RawVoterList.new
   end
   
     @raw_voter_list = RawVoterList.new
   end
   


@@ -169,7 +182,7 @@ class ElectionController < ApplicationController
     @election.voters. each do |voter|
       if voter.vote and voter.vote.confirmed?
         @voter_list << voter.email
     @election.voters. each do |voter|
       if voter.vote and voter.vote.confirmed?
         @voter_list << voter.email

-       @vote_list << voter.vote
+             @vote_list << voter.vote

       end
     end
 
       end
     end
 


@@ -186,20 +199,24 @@ class ElectionController < ApplicationController
 
       unless incoming_voters.entries.empty?
         incoming_voters.each do |new_voter|
 
       unless incoming_voters.entries.empty?
         incoming_voters.each do |new_voter|

-
+          new_voter.email.strip! # There's a trailing \r on all but the last in
+                                 # the list!

           if incoming_voters.email == 0
             new_voter.contacted = 1
           if incoming_voters.email == 0
             new_voter.contacted = 1

-         elsif incoming_voters.email == 1
-           email_voter( new_voter )
-           new_voter.contacted = 1
-         else
-           new_voter.contacted = 0
-         end
-       
-          # the new voter should be in good shape. save add to the election
-         new_voter.save
-          @election.voters << new_voter
+               elsif incoming_voters.email == 1
+                 email_voter( new_voter )
+            new_voter.contacted = 1
+               else
+                 new_voter.contacted = 0
+          end
+          if new_voter.valid?
+            # the new voter should be in good shape. save add to the election
+            @election.voters << new_voter
+                 new_voter.save
+          end
+          # TODO: Can we do some kind of AJAX error message for the voter being invalid?

         end
         end

+        @election.save

       end
  
       # reset the next time to have a the same default value for emailing
       end
  
       # reset the next time to have a the same default value for emailing


@@ -207,7 +224,10 @@ class ElectionController < ApplicationController
       @raw_voter_list.email = incoming_voters.email
     end
 
       @raw_voter_list.email = incoming_voters.email
     end
 

-    def email_voter
+    def email_voter(email=nil)
+      if email
+        
+      end

     end
 
 end
     end
 
 end