fix bug that allowed votes with more rankings than candidates to be recorded

[selectricity-live] / app / controllers / voter_controller.rb

diff --git a/app/controllers/voter_controller.rb b/app/controllers/voter_controller.rb
index 868bc4c7d2b994970bb17c0676651b06e9df0a97..4ff8140cae14929891528dd43f4b48b87ea4a42e 100644 (file)
--- a/app/controllers/voter_controller.rb
+++ b/app/controllers/voter_controller.rb
@@ -17,40 +17,69 @@
 # <http://www.gnu.org/licenses/>.
 
 class VoterController < ApplicationController
+  helper :sparklines
   layout 'main'
   require_dependency "voter"
   require_dependency "vote"
   require_dependency "election"
 
   def index
-    if params[:urlpassword]
+    if params[:election_id]
+      @election = Election.find(params[:election_id])
+      unless @election.authenticated?
+        @voter = OpenVoter.find(:all,
+          :conditions => ["session_id = ? and election_id = ?",
+          session.session_id, @election.id])[0]
+      
+
+        @voter = OpenVoter.new unless @voter
+
+        @voter.election = @election
+        @voter.session_id = session.session_id
+        @password = "open." + @election.id.to_s
+      end
+    elsif params[:urlpassword]
       password = params[:urlpassword]
 
       if @voter = FullVoter.find(:all,
         :conditions => [ "password = ?", password ] )[0]
-
-        @voter.vote = Vote.new if @voter.vote.nil?
-        @voter.vote.set_defaults! if @voter.vote.rankings.empty?
-
         @election = @voter.election
-        
-        # if the election is now finished 
-        if @election.enddate < Time.now
-          # compute and display results
+        @password = @voter.password
+      end
+    end
+
+    if @voter and @election
+      # initialize things if the vote is blank
+      if @voter.vote.nil?
+        @voter.vote = Vote.new 
+        @voter.save
+      end
     
-          @results = @election.results
-          @candidates = {}
-          @election.candidates.each {|c| @candidates[c.id] = c}
-          @names = @election.names_by_id
-          
-          @sidebar_content = render_to_string(:partial => 'results_sidebar')
-          render :action => 'results'
+      @voter.vote.set_defaults! if @voter.vote.rankings.empty?
+
+      # if the election is now finished 
+      if @election.enddate < Time.now
+        redirect_to :action => :results, :id => @password
+      else
+        @sidebar_content = render_to_string(:partial => 'vote_sidebar')
+        if @election.embeddable? and params[:embed] == "true"
+          #look for custom theme, and assign to instance variabels for widget use
+          if @election.embed_custom_string
+            @top_bar = SkinPicture.find(:first,
+            :conditions => ["filename = ?", @election.embed_custom_string + "top_bar.png"])
+            @default_image = SkinPicture.find(:first,
+            :conditions => ["filename = ?", @election.embed_custom_string + "default_image.png"])
+            @bg1 = SkinPicture.find(:first,
+            :conditions => ["filename = ?", @election.embed_custom_string + "bg1.png"])
+            @bg2 = SkinPicture.find(:first,
+            :conditions => ["filename = ?", @election.embed_custom_string + "bg2.png"])
+            @bottom_bar = SkinPicture.find(:first,
+            :conditions => ["filename = ?", @election.embed_custom_string + "bottom_bar.png"])
+          end
+          render :template => 'embed/full_vote', :layout => 'embed'
         else
-          @sidebar_content = render_to_string(:partial => 'vote_sidebar')
           render :action => 'full_vote'
         end
-      elsif params[:urlpassword] 
-        redirect_to :action => 'index'
       end
     end
   end
@@ -79,8 +108,8 @@ class VoterController < ApplicationController
   def details
     if authenticate
       @election = @voter.election
-      @votes = @election.votes.select {|v| v.confirmed? }.randomize
-      @voters = @votes.collect {|v| v.voter}.randomize
+      @votes = @election.votes.select {|v| v.confirmed? }.shuffle
+      @voters = @votes.collect {|v| v.voter}.shuffle
       render :action => 'details'
     else
       redirect_to :action => 'index'
@@ -99,10 +128,18 @@ class VoterController < ApplicationController
 
   def confirm
     if authenticate
-      @voter.vote.confirm!
-      render :action => 'thanks'
+      if @voter.vote.confirm!
+        if @voter.election.embeddable? and params[:embed] == "true" \
+          and @voter.election.early_results?
+          redirect_to :action => :results, :id => @password, :embed => 'true'
+        else
+          render :action => 'thanks'
+        end
+      else
+        redirect_to :action => 'index'
+      end
     else
-      redirect_to :action => 'index'
+        redirect_to :action => 'index'
     end
   end
   
@@ -117,11 +154,71 @@ class VoterController < ApplicationController
     end
   end
   
+  def results
+    debugger
+    if authenticate and
+      (@voter.election.early_results? \
+       or @voter.election.enddate < Time.now)
+      
+      @election = @voter.election
+      # compute and display results
+
+      @results = @election.results
+      @candidates = {}
+      @election.candidates.each {|c| @candidates[c.id] = c}
+      @names = @election.names_by_id
+        
+      @sidebar_content = render_to_string(:partial => 'results_sidebar')
+      #look for custom theme, and assign to instance variabels for widget use
+      if @election.embed_custom_string
+        @top_bar = SkinPicture.find(:first,
+        :conditions => ["filename = ?", @election.embed_custom_string + "top_bar.png"])
+        @default_image = SkinPicture.find(:first,
+        :conditions => ["filename = ?", @election.embed_custom_string + "default_image.png"])
+        @bg1 = SkinPicture.find(:first,
+        :conditions => ["filename = ?", @election.embed_custom_string + "bg1.png"])
+        @bg2 = SkinPicture.find(:first,
+        :conditions => ["filename = ?", @election.embed_custom_string + "bg2.png"])
+        @bottom_bar = SkinPicture.find(:first,
+        :conditions => ["filename = ?", @election.embed_custom_string + "bottom_bar.png"])
+      end
+      if @election.embeddable? and params[:embed] == "true"
+        render :template => 'embed/results', :layout => 'embed'
+      else
+        render :action => 'results'
+      end
+    else
+      redirect_to :action => 'index'
+    end
+  end
   
   private
   def authenticate
     password = params[:id]
-    @voter = FullVoter.find(:all, :conditions => [ "password = ?", password ] )[0]
+    if password == "open"
+      election = Election.find(params[:format])
+
+      # double check to make sure the election is not authenticated
+      unless election.authenticated?
+        @voter = OpenVoter.find(:all,
+          :conditions => ["session_id = ? and election_id = ?",
+                          session.session_id, election.id])[0]
+
+        # if the election is over, proceed
+        if (not @voter) and (election.enddate < Time.now)
+          @voter = OpenVoter.new
+          @voter.election = election
+        end
+
+        @password = "open." + election.id.to_s
+      end
+
+    else
+      @voter = FullVoter.find(:all,
+        :conditions => [ "password = ?", password ] )[0]
+      @password = @voter.password
+    end
+    @voter
   end
 end