Rename Selectricity API calls to more explicitly call itself quickvotes.

[selectricity-live] / app / models / selectricity_service.rb

diff --git a/app/models/selectricity_service.rb b/app/models/selectricity_service.rb
index 3f3e42ed4001796346d06d0278b0f8a8f704dd44..a3de89f4923a6f225c1dbe60e5e4d62909a2aed9 100644 (file)
--- a/app/models/selectricity_service.rb
+++ b/app/models/selectricity_service.rb
@@ -5,6 +5,12 @@ class SelectricityService < ActionWebService::Base
   def cast_quickvote(election_name, voter_id, vote_list)
     election = QuickVote.ident_to_quickvote election_name
     if election
   def cast_quickvote(election_name, voter_id, vote_list)
     election = QuickVote.ident_to_quickvote election_name
     if election

+      candidates=election.candidates.collect { |c| c.id }
+      vote_list[0].each do |vote|
+        raise ArgumentError.new("Invalid Candidate ID #{vote}") unless candidates.index(vote)
+      end
+      raise ArgumentError.new("You must rank all candidates") unless candidates.length <= vote_list[0].length
+      raise ArgumentError.new("Please rank each candidate only once") if vote_list[0].uniq!

       voter = QuickVoter.new
       voter.election = election
       voter.ipaddress = "XMLRPC Request"
       voter = QuickVoter.new
       voter.election = election
       voter.ipaddress = "XMLRPC Request"


@@ -15,12 +21,14 @@ class SelectricityService < ActionWebService::Base
       voter.save!
       voter.vote.confirm!
       voter.save!
       voter.save!
       voter.vote.confirm!
       voter.save!

+    else
+      raise ArgumentError.new("Cannot find election #{election_name}")

     end
   end
   def quickvote_candidate_ids_to_names(shortname, id_list)
     qv=QuickVote.ident_to_quickvote(shortname)
     candidates={}
     end
   end
   def quickvote_candidate_ids_to_names(shortname, id_list)
     qv=QuickVote.ident_to_quickvote(shortname)
     candidates={}

-    return [] unless qv
+    raise ArgumentError.new("Quickvote by name #{shortname} doesn't exist") unless qv

     qv.results
     qv.candidates.each {|c| candidates[c.id] = c}
     results=[]
     qv.results
     qv.candidates.each {|c| candidates[c.id] = c}
     results=[]


@@ -37,11 +45,9 @@ class SelectricityService < ActionWebService::Base
   def get_quickvote_results(shortname)
     #TODO: Validate shortname
     qv=QuickVote.ident_to_quickvote(shortname)
   def get_quickvote_results(shortname)
     #TODO: Validate shortname
     qv=QuickVote.ident_to_quickvote(shortname)

-    result=VoteResultStruct.new
-    result.errors=[]
+    result=QuickVoteResultStruct.new

     unless qv
     unless qv

-      result.errors << "No quickvote with name #{shortname} found!"
-      return result
+      raise ArgumentError.new("No quickvote with name #{shortname} found!")

     end
     qv.results
     result.plurality_winners=qv.plurality_result.winners
     end
     qv.results
     result.plurality_winners=qv.plurality_result.winners


@@ -53,11 +59,9 @@ class SelectricityService < ActionWebService::Base
   end
   def get_quickvote_candidate_map(shortname)
     qv=QuickVote.ident_to_quickvote(shortname)
   end
   def get_quickvote_candidate_map(shortname)
     qv=QuickVote.ident_to_quickvote(shortname)

-    result=CandidateMap.new
-    result.errors=[]
+    result=QuickVoteCandidateMap.new

     unless qv
     unless qv

-      result.errors << "No quickvote with name #{shortname} found!"
-      return result
+      raise ArgumentError.new("No quickvote with name #{shortname} found!")

     end
     candidates={}
     qv.candidates.each {|c| candidates[c.id] = c.name}
     end
     candidates={}
     qv.candidates.each {|c| candidates[c.id] = c.name}


@@ -65,16 +69,52 @@ class SelectricityService < ActionWebService::Base
     result.candidate_names=candidates.values
     result
   end
     result.candidate_names=candidates.values
     result
   end

+

   def get_quickvote_votes(shortname)
   def get_quickvote_votes(shortname)

-    qv=QuickVote.ident_to_quickvote(shortname)
-    votes=Array.new
+    qv = QuickVote.ident_to_quickvote(shortname)
+

     unless qv
     unless qv

-      return result
+      raise ArgumentError.new("Cannot find QuickVote #{shortname}")

     end
     end

-    qv.votes.each  do |vote|
-      votes << VoteInfo.new(:voter_id => vote.voter.id, :voter_ipaddress => vote.voter.ipaddress, :vote_time => vote.time.to_i)
+
+    qv.votes.collect do |vote|
+       QuickVoterInfo.new(:voter_id => vote.voter.id,
+                    :voter_ipaddress => vote.voter.ipaddress,
+                    :vote_time => vote.time.to_i,
+                    :vote => vote.votes,
+                    :voter_session_id => vote.voter.session_id)

     end
     end

-    return votes

   end
   end

-   
+
+  def list_quickvotes()
+    QuickVote.find(:all).collect do |election|
+      get_quickvote(election.name)
+    end
+  end
+
+  def get_quickvote(shortname)
+    unless election = QuickVote.ident_to_quickvote(shortname)
+      raise ArgumentError.new("Cannot find QuickVote named #{shortname}")
+    end
+
+    QuickVoteStruct.new(
+      :id => election.id,
+      :name => election.name,
+      :description => election.description,
+      :candidate_ids => election.candidates.collect {|c| c.id },
+      :candidate_names => election.candidates.collect {|c| c.name } )
+  end
+
+  def create_quickvote(election)
+    qv = QuickVote.new(:name => election.name,
+                       :description => election.description)
+    qv.candidate_names = election.candidate_names
+
+    if qv.save
+      return ""
+    else
+      raise ArgumentError.new("Saving quickvote FAILED:"+qv.errors.inspect)
+    end
+  end
+

 end
 end