* Refactor testcase code -- create_quickvote_fails assertion -- was using same block...

[selectricity-live] / app / models / quick_vote.rb

diff --git a/app/models/quick_vote.rb b/app/models/quick_vote.rb
index 5f566c6eb1e6575e1f8f6a7845e67ba21d963c53..ad727170f036c2b60019ffe6d7a63759d6ddfd8f 100644 (file)
--- a/app/models/quick_vote.rb
+++ b/app/models/quick_vote.rb
@@ -1,6 +1,7 @@
 class QuickVote < Election
   after_validation :create_candidates
   validates_uniqueness_of :name
 class QuickVote < Election
   after_validation :create_candidates
   validates_uniqueness_of :name

+  validates_presence_of :name

   attr_accessor :raw_candidates
   attr_accessor :reviewed
   attr_accessor :plurality_result
   attr_accessor :raw_candidates
   attr_accessor :reviewed
   attr_accessor :plurality_result


@@ -10,12 +11,19 @@ class QuickVote < Election
   attr_accessor :borda_result
 
   def validate
   attr_accessor :borda_result
 
   def validate

-    if @raw_candidates.length < 2
-      errors.add("You must list at least two candidates.")
+    if not @raw_candidates or @raw_candidates.length < 2
+        errors.add(nil, "You must list at least two candidates.")

     end
     end

-
+    

     if name =~ /[^A-Za-z0-9]/
     if name =~ /[^A-Za-z0-9]/

-      errors.add("The name must only include numbers and letters.")
+      errors.add(:name, "must only include numbers and letters.")
+    end
+    if name =~ /^[0-9]+$/
+      errors.add(:name, "must not be a number")
+    end
+    
+    if name =~ /^(create|index|confirm|change|results)$/
+      errors.add(:name, " is a reserved word.")

     end
   end
   
     end
   end
   


@@ -32,7 +40,7 @@ class QuickVote < Election
   end
 
   def name
   end
 
   def name

-    read_attribute( :name ).downcase()
+    read_attribute( :name ).downcase() if read_attribute( :name )

   end
 
   def reviewed?
   end
 
   def reviewed?


@@ -40,6 +48,7 @@ class QuickVote < Election
   end
 
   def create_candidates
   end
 
   def create_candidates

+    return unless errors.empty?

     @raw_candidates.each do |name|
       candidate = Candidate.new({:name => name})
       self.candidates << candidate
     @raw_candidates.each do |name|
       candidate = Candidate.new({:name => name})
       self.candidates << candidate


@@ -63,7 +72,6 @@ class QuickVote < Election
       preference_tally << voter.vote.rankings.sort.collect \
         { |ranking| ranking.candidate.id }
     end
       preference_tally << voter.vote.rankings.sort.collect \
         { |ranking| ranking.candidate.id }
     end

-

     @plurality_result = PluralityVote.new(plurality_tally).result
     @approval_result = ApprovalVote.new(approval_tally).result
     @condorcet_result = PureCondorcetVote.new(preference_tally).result
     @plurality_result = PluralityVote.new(plurality_tally).result
     @approval_result = ApprovalVote.new(approval_tally).result
     @condorcet_result = PureCondorcetVote.new(preference_tally).result


@@ -72,11 +80,11 @@ class QuickVote < Election
     #@runoff_result = InstantRunoffVote.new(preference_tally).result
     #@runoff_results = PluralityVote.new(preference_tally).result
 
     #@runoff_result = InstantRunoffVote.new(preference_tally).result
     #@runoff_results = PluralityVote.new(preference_tally).result
 

-

   end
 
   ### Convert a shortname or id into a QuickVote
   def self.ident_to_quickvote(ident)
   end
 
   ### Convert a shortname or id into a QuickVote
   def self.ident_to_quickvote(ident)

+    return nil unless ident

     if ident.match(/^\d+$/)
       quickvote = QuickVote.find(ident)
     else
     if ident.match(/^\d+$/)
       quickvote = QuickVote.find(ident)
     else