Suppress description of voter-verifiability unless election is verifiable.

[selectricity-live] / app / models / election.rb

diff --git a/app/models/election.rb b/app/models/election.rb
index ce7a0bceaff624a73231b6892b6743b0a36bd5f7..ac8d628b16f003a1848f78215aa6f9b4e9811412 100644 (file)
--- a/app/models/election.rb
+++ b/app/models/election.rb
@@ -1,12 +1,22 @@
+# Selectricity: Voting Machinery for the Masses
+# Copyright (C) 2007, 2008 Benjamin Mako Hill <mako@atdot.cc>
+# Copyright (C) 2007 Massachusetts Institute of Technology
+#
+# This program is free software. Please see the COPYING file for
+# details.
+

 class Election < ActiveRecord::Base
   has_many :candidates
   has_many :voters
   has_many :votes
   belongs_to :user
   validates_presence_of :name, :description
 class Election < ActiveRecord::Base
   has_many :candidates
   has_many :voters
   has_many :votes
   belongs_to :user
   validates_presence_of :name, :description

-  
+
+  # enforce constraints associated with dependencies (i.e., a kiosk
+  # election can't also be unauthenticated)
+  before_save :enforce_constraints
+

   #validate that method is one of the listed election types
   #validate that method is one of the listed election types

-  

   attr_reader :plurality_result
   attr_reader :approval_result
   attr_reader :condorcet_result
   attr_reader :plurality_result
   attr_reader :approval_result
   attr_reader :condorcet_result


@@ -14,7 +24,7 @@ class Election < ActiveRecord::Base
   attr_reader :borda_result
   
   require 'date'
   attr_reader :borda_result
   
   require 'date'

-  
+ 

   def initialize(params={})
     super
     self.enddate = read_attribute( :enddate ) || \
   def initialize(params={})
     super
     self.enddate = read_attribute( :enddate ) || \


@@ -23,7 +33,7 @@ class Election < ActiveRecord::Base
 
   def other_methods
     if election_method
 
   def other_methods
     if election_method

-      @other_methods = ELECTION_TYPES.reject {|i| i == election_method}
+      @other_methods = ELECTION_TYPES.keys.reject {|i| i == election_method}

     else
       @other_methods = nil
     end
     else
       @other_methods = nil
     end


@@ -55,7 +65,7 @@ class Election < ActiveRecord::Base
       reasons << "You must have at least two candidates."
     end
     
       reasons << "You must have at least two candidates."
     end
     

-    if self.voters.length <= 1
+    if self.voters.length <= 1 and self.authenticated?

       reasons << "You must have at least two voters."
     end
 
       reasons << "You must have at least two voters."
     end
 


@@ -64,11 +74,11 @@ class Election < ActiveRecord::Base
 
   def activate!
     self.active = 1
 
   def activate!
     self.active = 1

-    self.save!
+    self.save

   end
   
   def quickvote?
   end
   
   def quickvote?

-    self.class == 'QuickVote'
+    self.class == QuickVote

   end
 
   def active?
   end
 
   def active?


@@ -79,6 +89,14 @@ class Election < ActiveRecord::Base
     active == 2
   end
 
     active == 2
   end
 

+  def authenticated?
+    authenticated
+  end
+
+  def kiosk?
+    kiosk
+  end
+  

   def shortdesc
     shortdesc = description.split(/\n/)[0]
   end
   def shortdesc
     shortdesc = description.split(/\n/)[0]
   end


@@ -119,11 +137,11 @@ class Election < ActiveRecord::Base
       # skip if the voter has not voted or has an unconfirmed vote
       next unless voter.voted?
 
       # skip if the voter has not voted or has an unconfirmed vote
       next unless voter.voted?
 

-      plurality_tally << voter.vote.rankings.sort[0].candidate.id
+      plurality_tally << voter.vote.rankings.sort[0].candidate_id

       approval_tally << voter.vote.rankings.sort[0..1].collect \
       approval_tally << voter.vote.rankings.sort[0..1].collect \

-        { |ranking| ranking.candidate.id }
+        { |ranking| ranking.candidate_id }

       preference_tally << voter.vote.rankings.sort.collect \
       preference_tally << voter.vote.rankings.sort.collect \

-        { |ranking| ranking.candidate.id }
+        { |ranking| ranking.candidate_id }

     end
     
     @plurality_result = PluralityVote.new(plurality_tally).result
     end
     
     @plurality_result = PluralityVote.new(plurality_tally).result


@@ -149,6 +167,40 @@ class Election < ActiveRecord::Base
     
     names
   end
     
     names
   end

-end

 
 

+  def candidate_hash
+    hash = {}
+    self.candidates.each {|c| hash[c.id] = c}
+    return hash
+  end
+
+ 
+  # TODO now that this code is in here, we should go ahead and remove
+  # date checking from other places in the code
+  def after_find
+    if self.active < 2 and self.enddate < Time.now 
+      self.active = 2
+      self.save
+    end
+  end

 
 

+  def just_before_midnight(datetime)
+    if datetime.instance_of? DateTime
+      off = datetime.offset
+    else
+      off = Rational(datetime.utc_offset, 60*60*24)
+    end
+    return DateTime.new(datetime.year, datetime.month, datetime.day,
+                        23, 59, 59, off)
+  end
+
+  private
+  def enforce_constraints
+    # elections end just before midnight
+    self.enddate = just_before_midnight(self.enddate)
+    # kiosks can't be authenticated
+    self.authenticated = false if kiosk?
+    return true
+  end
+
+end