Refactored code to move it to a more object oriented mode and slimmed

[selectricity-live] / app / controllers / quickvote_controller.rb

diff --git a/app/controllers/quickvote_controller.rb b/app/controllers/quickvote_controller.rb
index 61a4c69261f714aba4461d7c1e5cf1b7a6c53e21..0b745af72e13c79548b227ff83174a79660e9b94 100644 (file)
--- a/app/controllers/quickvote_controller.rb
+++ b/app/controllers/quickvote_controller.rb
@@ -1,5 +1,5 @@
 class QuickvoteController < ApplicationController
-  layout 'hc'
+  layout 'main'
   model :quick_voter
   model :quick_vote
   model :vote
@@ -10,10 +10,9 @@ class QuickvoteController < ApplicationController
   #############################################################
 
   def create
-    breakpoint
     if params[:quickvote] 
       @quickvote = QuickVote.new(params[:quickvote])
-
+     
       # store the candidate grabbed through ajax and stored in flash
       @quickvote.candidatelist = flash[:candlist]
 
@@ -64,7 +63,7 @@ class QuickvoteController < ApplicationController
       # if the voter has not voted we destroy them
       if @voter and not @voter.voted?
         @voter.destroy
-       @voter = nil
+       @voter = nil
       end
 
       # if the voter does not exist or has has been destroyed, lets
@@ -74,12 +73,12 @@ class QuickvoteController < ApplicationController
         @voter = QuickVoter.new
         @voter.election = QuickVote.find_all( [ "name = ?", params[:votename] ] )[0]
         @voter.session_id = session.session_id
-
-       # create new vote and make it the defaulted sorted list
+        
+             # create new vote and make it the defaulted sorted list
         @voter.vote = Vote.new
-       @voter.save
-       @voter.vote.set_defaults!
-       @voter.reload
+             @voter.save
+             @voter.vote.set_defaults!
+             @voter.reload
       end
     else
       redirect_to :controller => 'site'
@@ -92,25 +91,29 @@ class QuickvoteController < ApplicationController
 
     # find out who the voter is for this election
     @voter = QuickVoter.find_all(["session_id = ? and election_id = ?", 
-                                  session.session_id, election.id])[0]
-
+                                 session.session_id, election.id])[0]
+  
     if not @voter
       # we have not seen this  voter before. something is wrong, try
       # again
       redirect_to quickvote_url( :votename => params[:votename] ) 
       
-    elsif @voter.voted?
+    elsif @voter.voted? 
       # this person has already voted, we try again
       flash[:notice] = "You have already voted!"
       redirect_to quickvote_url( :votename => params[:votename] )
       
     else
       # record the ip address for posterity
-      @voter.ipaddress = request.env["HTTP_X_FORWARDED_FOR"]
+      @voter.ipaddress = request.env["REMOTE_ADDR"]
       @voter.save
       
-      # toggle the confirmation bit
+      # save the time the vote was made for statistical use
+      @voter.vote.time = Time.now
+      
+      # toggle the confirmation bit      
       @voter.vote.confirm!
+     
       @voter.reload
       render :action => 'thanks'
     end
@@ -139,7 +142,7 @@ class QuickvoteController < ApplicationController
   ###############################################################
 
   def results
-    @election = QuickVote.find_all( ["name = ?", params[:votename]] )[0]
+    @election = QuickVote.find_all(["name = ?", params[:votename]] )[0]
 
     # initalize the tallies to empty arrays
     preference_tally = Array.new