X-Git-Url: https://projects.mako.cc/source/selectricity/blobdiff_plain/037ba376cadff08bca7185d7bc66410e10cf2975..6df3d73c4a0c52d79f3e8abe5180fbd73953a6a5:/test/unit/selectricityservice_test.rb

diff --git a/test/unit/selectricityservice_test.rb b/test/unit/selectricityservice_test.rb
index c4dd2cb..74b26d4 100644
--- a/test/unit/selectricityservice_test.rb
+++ b/test/unit/selectricityservice_test.rb
@@ -15,22 +15,7 @@ class SelectricityServiceTest < Test::Unit::TestCase
   end
   def test_create_quickvote
     election = ElectionStruct.new :name => "TestVote", :description => "Test Vote", :candidate_names => ["Apple", "Orange", "Banana", "Pineapple"]
-    result = invoke_delegated :vote, :create_quickvote, election
-    assert_instance_of String, result
-    assert_equal "", result
-    assert_equal(invoke_delegated(:vote,:list_quickvotes).length, 1)
-  end
-  def test_get_quickvote
-    test_create_quickvote
-    result = invoke_delegated :vote, :get_quickvote, "TestVote"
-    assert_instance_of ElectionStruct, result
-    assert_equal 0, result.name.casecmp("TestVote")
-    assert_equal result.description, "Test Vote"
-    assert_equal result.candidate_names.sort, ["Apple", "Orange", "Banana", "Pineapple"].sort
-    assert_not_nil result.id
-    assert result.id != 0
-    assert_nil result.candidate_ids.uniq!
-    assert result.candidate_ids.length == result.candidate_names.length
+    assert_create_quickvote_succeeds election
   end
   def test_cast_quickvote
     test_create_quickvote
@@ -54,17 +39,113 @@ class SelectricityServiceTest < Test::Unit::TestCase
   def test_create_mass_quickvote
     10.times do |t|
       election = ElectionStruct.new :name => "test#{t}", :description => "Test Vote", :candidate_names => ["Apple", "Orange", "Banana", "Pineapple"]
-      result = invoke_delegated :vote, :create_quickvote, election
-      assert_instance_of String, result
-      assert_equal "", result
-      assert_equal(invoke_delegated(:vote,:list_quickvotes).length, t+1)
+      assert_create_quickvote_succeeds election
     end
   end
   def test_create_quickvote_bad_name
     election = ElectionStruct.new :name => "invalid space", :description => "Test Vote", :candidate_names => ["Apple", "Orange", "Banana", "Pineapple"]
+    assert_create_quickvote_fails election
+  end
+  def test_create_quickvote_nil
+    election =  ElectionStruct.new
+    assert_create_quickvote_fails election
+  end
+  def test_create_quickvote_name_nil
+    election = ElectionStruct.new :name => "", :description => "Test Vote", :candidate_names => ["Apple", "Orange", "Banana", "Pineapple"]
+    assert_create_quickvote_fails election
+  end
+  def test_create_quickvote_description_nil
+    election = ElectionStruct.new :name => "foobar", :description => nil, :candidate_names => ["Apple", "Orange", "Banana", "Pineapple"]
+    assert_create_quickvote_fails election
+    
+  end
+  def test_create_quickvote_description_whitespace
+    election = ElectionStruct.new :name => "foobar", :description => "       ", :candidate_names => ["Apple", "Orange", "Banana", "Pineapple"]
+    assert_create_quickvote_fails election
+    election = ElectionStruct.new :name => "foobar", :description => "\t\t", :candidate_names => ["Apple", "Orange", "Banana", "Pineapple"]
+    assert_create_quickvote_fails election
+  end
+  def test_create_quickvote_candidates_nil
+    election = ElectionStruct.new :name => "foobar", :description => "valid", :candidate_names => nil
+    assert_create_quickvote_fails election
+  end
+  def test_create_quickvote_insufficient_candidates
+    election = ElectionStruct.new :name => "foobar", :description => "valid", :candidate_names => ["Apple"]
+    assert_create_quickvote_fails election
+  end
+  def test_create_quickvote_candidates_whitespace
+    election = ElectionStruct.new :name => "foobar", :description => "valid", :candidate_names => [" ", "   ", "       ", "         "]
+    assert_create_quickvote_fails election
+  end
+  def test_create_quickvote_dupe_candidates
+    election = ElectionStruct.new :name => "foobar", :description => "valid", :candidate_names => ["Apple", "Apple", "Apple", "Apple"]
+    assert_create_quickvote_fails election
+
+    # Previous may pass coincidentally if a uniq! then a sizecheck reveals too few unique names
+    # We don't want this to happen. Dupe canidates should fail regardless of how many are left.
+
+    election = ElectionStruct.new :name => "foobar", :description => "valid", :candidate_names => ["Apple", "Apple", "Orange", "Orange", "Pineapple" ,  "Pineapple"]
+    assert_create_quickvote_fails election
+  end
+  def test_create_quickvote_candidates_nil_mixed
+    election = ElectionStruct.new :name => "foobar", :description => "valid", :candidate_names => ["Apple", nil ]
+    assert_create_quickvote_fails election
+  end
+  def test_create_quickvote_description_xmlescape
+    # Will an embedded XML element bork the table?
+    election = ElectionStruct.new :name => "foobar", :description => "test </string>", :candidate_names => ["Apple", "Orange", "Banana", "Pineapple"]
+    assert_create_quickvote_succeeds election
+  end
+  def test_create_quickvote_unprintable_description
+    election =  ElectionStruct.new :name => "foobar", :description => "test \x01\x02\x03\x04\x05\x06\x07\x08", :candidate_names => ["Apple", "Orange", "Banana", "Pineapple"]
+    assert_create_quickvote_succeeds election
+  end
+  def test_quickvote_proper_results
+    election =  ElectionStruct.new :name => "favdev", :description => "Who is your favorite developer?", :candidate_names => ["mako", "jdong", "justin"]
+    assert_create_quickvote_succeeds election
+    reflection = invoke_delegated :vote, :get_quickvote, "favdev"
+    candidates = {}
+    reflection.candidate_names.each_with_index do |name, index|
+      candidates[name] =  reflection.candidate_ids[index]
+    end
+    25.times do |t|
+      vote = [candidates["jdong"], candidates["mako"], candidates["justin"]]
+      invoke_delegated :vote, :cast_quickvote, "favdev", "1:#{t}", [vote]
+    end
+    5.times do |t|
+      vote = [candidates["mako"], candidates["justin"], candidates["jdong"]]
+      invoke_delegated :vote, :cast_quickvote, "favdev", "2:#{t}", [vote]
+    end
+    10.times do |t|
+      vote = [candidates["justin"], candidates["mako"], candidates["jdong"]]
+      invoke_delegated :vote, :cast_quickvote, "favdev", "3:#{t}", [vote]
+    end
+    results=invoke_delegated(:vote, :get_quickvote_results, "favdev")
+    assert_equal results.approval_winners, [candidates["mako"]]
+    assert_equal results.borda_winners, [candidates["jdong"]]
+    assert_equal results.plurality_winners, [candidates["jdong"]]
+    assert_equal results.condorcet_winners, [candidates["jdong"]]
+    assert_equal results.ssd_winners, [candidates["jdong"]]
+    assert_equal results.errors.length, 0
+  end
+  private
+  def assert_create_quickvote_succeeds(election)
+    # Checks if a created quickvote is identical when retrieved
+    old_len=invoke_delegated(:vote,:list_quickvotes).length
+    result = invoke_delegated :vote, :create_quickvote, election
+    assert_equal result, ""
+    reflection = invoke_delegated :vote, :get_quickvote, election.name
+    assert_equal election.description, reflection.description
+    assert_equal 0, election.name.casecmp(reflection.name)
+    assert_equal election.candidate_names, reflection.candidate_names
+    assert_equal(invoke_delegated(:vote,:list_quickvotes).length, old_len+1)
+  end
+  def assert_create_quickvote_fails(election)
+    # Helper function to check that creating this quickvote fails
+    old_len=invoke_delegated(:vote,:list_quickvotes).length
     result = invoke_delegated :vote, :create_quickvote, election
     assert_instance_of String, result
     assert_not_equal result.length, 0
-    assert_equal(invoke_delegated(:vote,:list_quickvotes).length, 0)
+    assert_equal(invoke_delegated(:vote,:list_quickvotes).length, old_len)
   end
 end