From: John Dong Date: Fri, 17 Aug 2007 20:02:31 +0000 (-0400) Subject: * Refactor testcase code -- create_quickvote_fails assertion -- was using same block... X-Git-Url: https://projects.mako.cc/source/selectricity-live/commitdiff_plain/a7c9f5ae54334ea4c0c1308b931b143cf1449f48?hp=3b4bd99898faa4b3ebdc78b2e5a2e7047c1a6450 * Refactor testcase code -- create_quickvote_fails assertion -- was using same block of code repetivitely Add more testcases for improper data * Passing in a nil ElectionStruct to quickvotes * Passing in only nil {name, description, candidates} * Passing in whitespace for name, description, candidates * Passing in duplicate candidates * Passing in dirty HTML in description field - IMO this may not be a "bug" -- we should rather assert that the view will not be injected with HTML. It may be desirable (a feature) to store HTML-ish text in the database. --- diff --git a/test/unit/selectricityservice_test.rb b/test/unit/selectricityservice_test.rb index c4dd2cb..e3f5906 100644 --- a/test/unit/selectricityservice_test.rb +++ b/test/unit/selectricityservice_test.rb @@ -62,9 +62,61 @@ class SelectricityServiceTest < Test::Unit::TestCase end def test_create_quickvote_bad_name election = ElectionStruct.new :name => "invalid space", :description => "Test Vote", :candidate_names => ["Apple", "Orange", "Banana", "Pineapple"] + assert_create_quickvote_fails election + end + def test_create_quickvote_nil + election = ElectionStruct.new + assert_create_quickvote_fails election + end + def test_create_quickvote_name_nil + election = ElectionStruct.new :name => "", :description => "Test Vote", :candidate_names => ["Apple", "Orange", "Banana", "Pineapple"] + assert_create_quickvote_fails election + end + def test_create_quickvote_description_nil + election = ElectionStruct.new :name => "foobar", :description => nil, :candidate_names => ["Apple", "Orange", "Banana", "Pineapple"] + assert_create_quickvote_fails election + + end + def test_create_quickvote_description_whitespace + election = ElectionStruct.new :name => "foobar", :description => " ", :candidate_names => ["Apple", "Orange", "Banana", "Pineapple"] + assert_create_quickvote_fails election + election = ElectionStruct.new :name => "foobar", :description => "\t\t", :candidate_names => ["Apple", "Orange", "Banana", "Pineapple"] + assert_create_quickvote_fails election + end + def test_create_quickvote_candidates_nil + election = ElectionStruct.new :name => "foobar", :description => nil, :candidate_names => nil + assert_create_quickvote_fails election + end + def test_create_quickvote_insufficient_candidates + election = ElectionStruct.new :name => "foobar", :description => nil, :candidate_names => ["Apple"] + assert_create_quickvote_fails election + end + def test_create_quickvote_candidates_whitespace + election = ElectionStruct.new :name => "foobar", :description => "valid", :candidate_names => [" ", " ", " ", " "] + assert_create_quickvote_fails election + end + def test_create_quickvote_dupe_candidates + election = ElectionStruct.new :name => "foobar", :description => nil, :candidate_names => ["Apple", "Apple", "Apple", "Apple"] + assert_create_quickvote_fails election + end + def test_create_quickvote_candidates_nil_mixed + election = ElectionStruct.new :name => "foobar", :description => nil, :candidate_names => ["Apple", nil ] + assert_create_quickvote_fails election + end + def test_create_quickvote_description_htmlescape + election = ElectionStruct.new :name => "foobar", :description => "test", :candidate_names => ["Apple", "Orange", "Banana", "Pineapple"] + result = invoke_delegated :vote, :create_quickvote, election + assert_equal result, "" + reflection = invoke_delegated :vote, :get_quickvote, election.name + assert_not_equal election.description, reflection.description + assert_not_equal reflection.description.length, 0 + end + private + def assert_create_quickvote_fails(election) + old_len=invoke_delegated(:vote,:list_quickvotes).length result = invoke_delegated :vote, :create_quickvote, election assert_instance_of String, result assert_not_equal result.length, 0 - assert_equal(invoke_delegated(:vote,:list_quickvotes).length, 0) + assert_equal(invoke_delegated(:vote,:list_quickvotes).length, old_len) end end