X-Git-Url: https://projects.mako.cc/source/selectricity-live/blobdiff_plain/037ba376cadff08bca7185d7bc66410e10cf2975..23c5d764866ae11c5a65cd872647ce026544decb:/test/unit/selectricityservice_test.rb

diff --git a/test/unit/selectricityservice_test.rb b/test/unit/selectricityservice_test.rb
index c4dd2cb..446520b 100644
--- a/test/unit/selectricityservice_test.rb
+++ b/test/unit/selectricityservice_test.rb
@@ -62,9 +62,68 @@ class SelectricityServiceTest < Test::Unit::TestCase
   end
   def test_create_quickvote_bad_name
     election = ElectionStruct.new :name => "invalid space", :description => "Test Vote", :candidate_names => ["Apple", "Orange", "Banana", "Pineapple"]
+    assert_create_quickvote_fails election
+  end
+  def test_create_quickvote_nil
+    election =  ElectionStruct.new
+    assert_create_quickvote_fails election
+  end
+  def test_create_quickvote_name_nil
+    election = ElectionStruct.new :name => "", :description => "Test Vote", :candidate_names => ["Apple", "Orange", "Banana", "Pineapple"]
+    assert_create_quickvote_fails election
+  end
+  def test_create_quickvote_description_nil
+    election = ElectionStruct.new :name => "foobar", :description => nil, :candidate_names => ["Apple", "Orange", "Banana", "Pineapple"]
+    assert_create_quickvote_fails election
+    
+  end
+  def test_create_quickvote_description_whitespace
+    election = ElectionStruct.new :name => "foobar", :description => "       ", :candidate_names => ["Apple", "Orange", "Banana", "Pineapple"]
+    assert_create_quickvote_fails election
+    election = ElectionStruct.new :name => "foobar", :description => "\t\t", :candidate_names => ["Apple", "Orange", "Banana", "Pineapple"]
+    assert_create_quickvote_fails election
+  end
+  def test_create_quickvote_candidates_nil
+    election = ElectionStruct.new :name => "foobar", :description => "valid", :candidate_names => nil
+    assert_create_quickvote_fails election
+  end
+  def test_create_quickvote_insufficient_candidates
+    election = ElectionStruct.new :name => "foobar", :description => "valid", :candidate_names => ["Apple"]
+    assert_create_quickvote_fails election
+  end
+  def test_create_quickvote_candidates_whitespace
+    election = ElectionStruct.new :name => "foobar", :description => "valid", :candidate_names => [" ", "   ", "       ", "         "]
+    assert_create_quickvote_fails election
+  end
+  def test_create_quickvote_dupe_candidates
+    election = ElectionStruct.new :name => "foobar", :description => "valid", :candidate_names => ["Apple", "Apple", "Apple", "Apple"]
+    assert_create_quickvote_fails election
+
+    # Previous may pass coincidentally if a uniq! then a sizecheck reveals too few unique names
+    # We don't want this to happen. Dupe canidates should fail regardless of how many are left.
+
+    election = ElectionStruct.new :name => "foobar", :description => "valid", :candidate_names => ["Apple", "Apple", "Orange", "Orange", "Pineapple" ,  "Pineapple"]
+    assert_create_quickvote_fails election
+  end
+  def test_create_quickvote_candidates_nil_mixed
+    election = ElectionStruct.new :name => "foobar", :description => "valid", :candidate_names => ["Apple", nil ]
+    assert_create_quickvote_fails election
+  end
+  def test_create_quickvote_description_xmlescape
+    # Will an embedded XML element bork the table?
+    election = ElectionStruct.new :name => "foobar", :description => "test </string>", :candidate_names => ["Apple", "Orange", "Banana", "Pineapple"]
+    result = invoke_delegated :vote, :create_quickvote, election
+    assert_equal result, ""
+    reflection = invoke_delegated :vote, :get_quickvote, election.name
+    assert_equal election.description, reflection.description
+    assert_not_equal reflection.description.length, 0
+  end
+  private
+  def assert_create_quickvote_fails(election)
+    old_len=invoke_delegated(:vote,:list_quickvotes).length
     result = invoke_delegated :vote, :create_quickvote, election
     assert_instance_of String, result
     assert_not_equal result.length, 0
-    assert_equal(invoke_delegated(:vote,:list_quickvotes).length, 0)
+    assert_equal(invoke_delegated(:vote,:list_quickvotes).length, old_len)
   end
 end