From: Benjamin Mako Hill <mako@atdot.cc>
Date: Fri, 21 Jun 2024 06:51:39 +0000 (+1000)
Subject: initial patch to cause scuttle to work with PHP 8.2
X-Git-Url: https://projects.mako.cc/source/scuttle/commitdiff_plain/91d3a96bb7741ba92d2d3d7a7dc7d18e0d79688f?ds=sidebyside;hp=91d3a96bb7741ba92d2d3d7a7dc7d18e0d79688f

initial patch to cause scuttle to work with PHP 8.2

PHP broke a number of syntactical things that were key parts of
scuttle.

- changed the way that objects are initialized to use the "new
  Class()" syntax and replace the ClassName functions with __construct.

- add conditional isset() checks to set variables to null before they
  are used (esp. in templates)

- rework the ServiceFactory so they are called different and have
  access to the database material

- replace deprecated builtins like call_user_func_array() and
  create_function()

- handle the explosion of urls a little more gracefully so we don't
  have reply on access missing items of arrays.

- search.inc.php relies on a bunch of variables that aren't set
  anywhere in the code. I've removed a bunch of stuff from to quite
  things but there might be something I'm missing here.
---