minor optimization

[rubyvote] / lib / rubyvote / condorcet.rb

diff --git a/lib/rubyvote/condorcet.rb b/lib/rubyvote/condorcet.rb
index b3bdcd6d71a253671b795a59c70f471d73c1ab15..4dd1745ebbaad2f16e57052bc1836c4cf9b332b2 100644 (file)
--- a/lib/rubyvote/condorcet.rb
+++ b/lib/rubyvote/condorcet.rb
@@ -33,53 +33,103 @@
 
 class CondorcetVote < ElectionVote
 
 
 class CondorcetVote < ElectionVote
 

+  attr_accessor :results
+
+  def initialize(votes=nil)
+    unless defined?(@candidates)
+      @candidates = Array.new
+      votes.each do |vote_row|
+        vote_row = vote_row.flatten if vote_row.class == Array
+        vote_row.each do |vote| 
+          @candidates << vote unless @candidates.include?(vote)
+        end
+      end
+    end
+    super(votes)
+    @results = Array.new
+  end
+

   def tally_vote(vote=nil)
 
     vote.each_with_index do |winner, index|
   def tally_vote(vote=nil)
 
     vote.each_with_index do |winner, index|

-      # only run through this if this *is* preferred to something
-      break if vote.length - 1 == index
-      losers = vote.last( vote.length - index )
-
-      losers.each do |loser|
-        next if winner == loser
+      if vote.flatten.length < @candidates.length
+        implied_losers = @candidates.select { |c| not vote.include?(c) }
+        vote.push(implied_losers)
+      end
+      if vote.length - 1 == index
+        losers = []
+      else
+        losers = vote.flatten.last( vote.flatten.length - index - 1)
+      end

 
 

-        @votes[winner] = Hash.new unless @votes.has_key?(winner)
-        @votes[loser] = Hash.new unless @votes.has_key?(loser)
+      losers.each do |place|
+        place = [place] unless place.class == Array
+        place.each do |loser|
+          

 
 

-        if @votes[winner].has_key?(loser)
-          @votes[winner][loser] += 1
-        else
-          @votes[winner][loser] = 1
-        end
+          @votes[winner] = Hash.new unless @votes.has_key?(winner)
+          @votes[loser] = Hash.new unless @votes.has_key?(loser)

 
 

-        # make sure we have a comparable object
-        @votes[loser][winner] = 0 unless @votes[loser].has_key?( winner )
+          if @votes[winner].has_key?(loser)
+            @votes[winner][loser] += 1
+          else
+            @votes[winner][loser] = 1
+          end

 
 

-        @candidates << loser unless @candidates.include?( loser )
+          # make sure we have a comparable object
+          @votes[loser][winner] = 0 unless @votes[loser].has_key?( winner )
+        end

       end
       end

+    end
+  end

 
 

-      @candidates << winner unless @candidates.include?( winner )
+  def results
+    if @results.size < 2 && (not @candidates.empty?)
+      tabulate

     end
     end

+    @results
+  end
+
+  def result
+    find_only_winner unless @winner
+    @winner

   end
 
   protected
   end
 
   protected

+

   def verify_vote(vote=nil)
     vote.instance_of?( Array ) and
       vote == vote.uniq
   end
   def verify_vote(vote=nil)
     vote.instance_of?( Array ) and
       vote == vote.uniq
   end

-  
+
+  def tabulate
+    find_only_winner unless @winner
+    until @candidates.empty? 
+      aResult = resultFactory( self )
+      @results << aResult.winners
+      filter_out(aResult)
+    end
+  end
+
+  def find_only_winner
+    @winner = resultFactory( self )
+    @results << @winner.winners
+    filter_out(@winner)
+  end
+

 end
 
 class PureCondorcetVote < CondorcetVote
   def result
 end
 
 class PureCondorcetVote < CondorcetVote
   def result

-    PureCondorcetResult.new( self )
+    PureCondorcetResult.new(self)

   end
 end
 
 class CloneproofSSDVote < CondorcetVote
   end
 end
 
 class CloneproofSSDVote < CondorcetVote

-  def result
-    CloneproofSSDResult.new( self )
+  def resultFactory(init)
+    CloneproofSSDResult.new(init)

   end
   end

+

 end
 
 
 end
 
 


@@ -104,6 +154,7 @@ class CondorcetResult < ElectionResult
     votes = @election.votes unless votes
 
     defeats = Array.new
     votes = @election.votes unless votes
 
     defeats = Array.new

+    candidates = [candidates] unless candidates.class == Array

     candidates.each do |candidate|
       candidates.each do |challenger|
         next if candidate == challenger
     candidates.each do |candidate|
       candidates.each do |challenger|
         next if candidate == challenger


@@ -175,14 +226,18 @@ class CloneproofSSDResult < CondorcetResult
       # see the array with the standard defeats
       transitive_defeats = self.defeats(candidates, votes)
 
       # see the array with the standard defeats
       transitive_defeats = self.defeats(candidates, votes)
 

+      candidates = [candidates] unless candidates.class == Array

       candidates.each do |cand1|
         candidates.each do |cand2|
       candidates.each do |cand1|
         candidates.each do |cand2|

-          candidates.each do |cand3|
-            if transitive_defeats.include?( [ cand2, cand1 ] ) and
-                transitive_defeats.include?( [ cand1, cand3 ] ) and
-                not transitive_defeats.include?( [ cand2, cand3 ] ) and
-                not cand2 == cand3
-              transitive_defeats << [ cand2, cand3 ]
+          unless cand1 == cand2
+            candidates.each do |cand3|
+              if not cand2 == cand3 and 
+                  not cand1 == cand3 and 
+                  transitive_defeats.include?( [ cand2, cand1 ] ) and
+                  transitive_defeats.include?( [ cand1, cand3 ] ) and
+                  not transitive_defeats.include?( [ cand2, cand3 ] )
+                transitive_defeats << [ cand2, cand3 ]
+              end

             end
           end
         end
             end
           end
         end