commit needs to write latest rev to file too, as text may be changed such as a sig...
[mw] / src / mw / clicommands.py
index 9efffd4a2883a68476d1723befe4f446170b81b3..3be6da394fec01f618cf5afc11e42805e56f88fd 100644 (file)
@@ -1,6 +1,6 @@
 ###
 # mw - VCS-like nonsense for MediaWiki websites
-# Copyright (C) 2010  Ian Weller <ian@ianweller.org>
+# Copyright (C) 2011  Ian Weller <ian@ianweller.org> and others
 #
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -44,7 +44,7 @@ class CommandBase(object):
 
     def main(self):
         (self.options, self.args) = self.parser.parse_args()
-        self.args = self.args[1:] # don't need the first thing
+        self.args = self.args[1:]  # don't need the first thing
         self._do_command()
 
     def _do_command(self):
@@ -78,10 +78,10 @@ class CommandBase(object):
             sys.exit(1)
 
     def _api_setup(self):
-        cookie_file = os.path.join(self.metadir.location, 'cookies')
+        cookie_filename = os.path.join(self.metadir.location, 'cookies')
         self.api_url = self.metadir.config.get('remote', 'api_url')
         self.api = simplemediawiki.MediaWiki(self.api_url,
-                                             cookie_file=cookie_file)
+                                             cookie_file=cookie_filename)
 
 
 class InitCommand(CommandBase):
@@ -121,11 +121,13 @@ class LogoutCommand(CommandBase):
         except OSError:
             pass
 
+
 class PullCategoryMembersCommand(CommandBase):
 
     def __init__(self):
         usage = '[options] PAGENAME ...'
-        CommandBase.__init__(self, 'pullcat', 'add remote pages to repo belonging to the given category', usage)
+        CommandBase.__init__(self, 'pullcat', 'add remote pages to repo '
+                             'belonging to the given category', usage)
 
     def _do_command(self):
         self._die_if_no_init()
@@ -133,24 +135,23 @@ class PullCategoryMembersCommand(CommandBase):
         pages = []
         pages += self.args
         for these_pages in [pages[i:i + 25] for i in range(0, len(pages), 25)]:
-#http://commons.wikimedia.org/w/api.php?action=query&format=xmlfm&generator=categorymembers&gcmlimit=500&gcmtitle=Category:User:Esby
-              data = {
-                      'action': 'query',
-                      'gcmtitle': '|'.join(these_pages),
-                      'generator' : 'categorymembers',
-                      'gcmlimit' : 500
-              }
+            data = {
+                'action': 'query',
+                'gcmtitle': '|'.join(these_pages),
+                'generator': 'categorymembers',
+                'gcmlimit': 500
+            }
         response = self.api.call(data)['query']['pages']
         for pageid in response.keys():
-          pagename = response[pageid]['title']
-          print pagename
-          pullc = PullCommand()
-          pullc.args = [pagename.encode('utf-8')]
-          pullc._do_command()
+            pagename = response[pageid]['title']
+            print pagename
+            pullc = PullCommand()
+            pullc.args = [pagename.encode('utf-8')]
+            pullc._do_command()
 
 
 class PullCommand(CommandBase):
-
+    
     def __init__(self):
         usage = '[options] PAGENAME ...'
         CommandBase.__init__(self, 'pull', 'add remote pages to repo', usage)
@@ -160,7 +161,20 @@ class PullCommand(CommandBase):
         self._api_setup()
         pages = []
         pages += self.args
-        for these_pages in [pages[i:i + 25] for i in range(0, len(pages), 25)]:
+
+        # Pull should work with pagename, filename, or working directory
+        converted_pages = []
+        if pages == []:
+            pages = self.metadir.working_dir_status().keys()
+        for pagename in pages:
+            if '.wiki' in pagename:
+                converted_pages.append(
+                    mw.metadir.filename_to_pagename(pagename[:-5]))
+            else:
+                converted_pages.append(pagename)
+        pages = converted_pages
+
+        for these_pages in [pages[i:i + 25] for i in range(0, len(pages), 25)]: # XXX ?
             data = {
                     'action': 'query',
                     'titles': '|'.join(these_pages),
@@ -168,23 +182,44 @@ class PullCommand(CommandBase):
                     'rvprop': 'ids|flags|timestamp|user|comment|content',
             }
             response = self.api.call(data)['query']['pages']
+            # for every pageid, returns dict.keys() = {'lastrevid', 'pageid', 'title', 'counter', 'length', 'touched': u'2011-02-02T19:32:04Z', 'ns', 'revisions' {...}}
             for pageid in response.keys():
                 pagename = response[pageid]['title']
+                
+                # XXX is the revisions list a sorted one, should I use [0] or [-1]?
+                last_wiki_rev_comment = response[pageid]['revisions'][0]['comment']
+                last_wiki_rev_user = response[pageid]['revisions'][0]['user']
+                
+                # check if working file is modified or if wiki page doesn't exists
+                status = self.metadir.working_dir_status()
+                filename = mw.metadir.pagename_to_filename(pagename)
+                full_filename = os.path.join(self.metadir.root, filename + '.wiki')
+                if filename + '.wiki' in status and \
+                    status[filename + '.wiki' ] in ['M']:
+                    print 'skipping:       %s -- uncommitted modifications ' % (pagename)
+                    continue
                 if 'missing' in response[pageid].keys():
                     print '%s: %s: page does not exist, file not created' % \
                             (self.me, pagename)
                     continue
-                revids = [x['revid'] for x in response[pageid]['revisions']]
-                revids.sort()
-                self.metadir.pagedict_add(pagename, pageid, revids[-1])
-                self.metadir.pages_add_rv(int(pageid),
-                                          response[pageid]['revisions'][0])
-                filename = mw.metadir.pagename_to_filename(pagename)
-                with file(os.path.join(self.metadir.root, filename + '.wiki'),
-                          'w') as fd:
-                    data = response[pageid]['revisions'][0]['*']
-                    data = data.encode('utf-8')
-                    fd.write(data)
+
+                wiki_revids = sorted([x['revid'] for x in response[pageid]['revisions']])
+                last_wiki_revid = wiki_revids[-1]
+                working_revids = sorted(self.metadir.pages_get_rv_list({'id' : pageid}))
+                last_working_revid = working_revids[-1]
+                if ( os.path.exists(full_filename) and 
+                        last_wiki_revid == last_working_revid):
+                    print 'wiki unchanged: %s' % (pagename)
+                else:
+                    print 'pulling:        %s : %s -- %s' % (
+                        pagename, last_wiki_rev_comment, last_wiki_rev_user)
+                    self.metadir.pagedict_add(pagename, pageid, last_wiki_revid)
+                    self.metadir.pages_add_rv(int(pageid),
+                                              response[pageid]['revisions'][0])
+                    with file(full_filename, 'w') as fd:
+                        data = response[pageid]['revisions'][0]['*']
+                        data = data.encode('utf-8')
+                        fd.write(data)
 
 
 class StatusCommand(CommandBase):
@@ -196,8 +231,8 @@ class StatusCommand(CommandBase):
     def _do_command(self):
         self._die_if_no_init()
         status = self.metadir.working_dir_status()
-        for file in status:
-            print '%s %s' % (status[file], file)
+        for filename in status:
+            print '%s %s' % (status[filename], filename)
 
 
 class DiffCommand(CommandBase):
@@ -208,10 +243,10 @@ class DiffCommand(CommandBase):
     def _do_command(self):
         self._die_if_no_init()
         status = self.metadir.working_dir_status()
-        for file in status:
-            if status[file] == 'U':
+        for filename in status:
+            if status[filename] == 'M':
                 print self.metadir.diff_rv_to_working(
-                        mw.metadir.filename_to_pagename(file[:-5])),
+                        mw.metadir.filename_to_pagename(filename[:-5])),
 
 
 class CommitCommand(CommandBase):
@@ -233,9 +268,9 @@ class CommitCommand(CommandBase):
         self._api_setup()
         status = self.metadir.working_dir_status(files=self.args)
         nothing_to_commit = True
-        for file in status:
-            print '%s %s' % (status[file], file)
-            if status[file] in ['U']:
+        for filename in status:
+            print '%s %s' % (status[filename], filename)
+            if status[filename] in ['M']:
                 nothing_to_commit = False
         if nothing_to_commit:
             print 'nothing to commit'
@@ -245,28 +280,28 @@ class CommitCommand(CommandBase):
             edit_summary = raw_input()
         else:
             edit_summary = self.options.edit_summary
-        for file in status:
-            if status[file] in ['U']:
+        for file_num, filename in enumerate(status):
+            if status[filename] in ['M']:
                 # get edit token
                 data = {
                         'action': 'query',
                         'prop': 'info|revisions',
                         'intoken': 'edit',
-                        'titles': mw.metadir.filename_to_pagename(file[:-5]),
+                        'titles': mw.metadir.filename_to_pagename(filename[:-5]),
                 }
                 response = self.api.call(data)
-                pageid = response['query']['pages'].keys()[0]
-                revid = response['query']['pages'][pageid]['revisions'][0]\
-                        ['revid']
-                awaitedrevid = self.metadir.pages_get_rv_list({'id': pageid})\
-                        [0]
+                pages = response['query']['pages']
+                pageid = pages.keys()[0]
+                revid = pages[pageid]['revisions'][0]['revid']
+                awaitedrevid = \
+                        self.metadir.pages_get_rv_list({'id': pageid})[0]
                 if revid != awaitedrevid:
                     print 'warning: edit conflict detected on %s (%s -> %s) ' \
                             '-- skipping!' % (file, awaitedrevid, revid)
                     continue
-                edittoken = response['query']['pages'][pageid]['edittoken']
-                filename = os.path.join(self.metadir.root, file)
-                text = codecs.open(filename, 'r', 'utf-8').read()
+                edittoken = pages[pageid]['edittoken']
+                full_filename = os.path.join(self.metadir.root, filename)
+                text = codecs.open(full_filename, 'r', 'utf-8').read()
                 text = text.encode('utf-8')
                 if (len(text) != 0) and (text[-1] == '\n'):
                     text = text[:-1]
@@ -275,7 +310,7 @@ class CommitCommand(CommandBase):
                 textmd5 = md5.hexdigest()
                 data = {
                         'action': 'edit',
-                        'title': mw.metadir.filename_to_pagename(file[:-5]),
+                        'title': mw.metadir.filename_to_pagename(filename[:-5]),
                         'token': edittoken,
                         'text': text,
                         'md5': textmd5,
@@ -284,15 +319,22 @@ class CommitCommand(CommandBase):
                 if self.options.bot:
                     data['bot'] = 'bot'
                 response = self.api.call(data)
+                if 'error' in response:
+                    if 'code' in response['error']:
+                        if response['error']['code'] == 'permissiondenied':
+                            print 'Permission denied -- try running "mw login"'
+                            return
                 if response['edit']['result'] == 'Success':
                     if 'nochange' in response['edit']:
                         print 'warning: no changes detected in %s - ' \
-                                'skipping and removing ending LF' % file
-                        self.metadir.clean_page(file[:-5])
+                                'skipping and removing ending LF' % filename
+                        pagename = mw.metadir.filename_to_pagename(filename[:-5])
+                        self.metadir.clean_page(pagename)
                         continue
                     if response['edit']['oldrevid'] != revid:
-                        print 'warning: edit conflict detected on %s -- ' \
-                                'skipping!' % file
+                        print 'warning: edit conflict detected on %s (%s -> %s) ' \
+                                '-- skipping!' % (file, 
+                                response['edit']['oldrevid'], revid)
                         continue
                     data = {
                             'action': 'query',
@@ -304,8 +346,15 @@ class CommitCommand(CommandBase):
                     response = self.api.call(data)['query']['pages']
                     self.metadir.pages_add_rv(int(pageid),
                                               response[pageid]['revisions'][0])
-                    print 'waiting 10s before processing the next file'
-                    time.sleep(10)
+                    # need to write latest rev to file too, as text may be changed
+                    # such as a signature
+                    with file(full_filename, 'w') as fd:
+                        data = response[pageid]['revisions'][0]['*']
+                        data = data.encode('utf-8')
+                        fd.write(data)
+                    if file_num != len(status) - 1:
+                        print 'waiting 3s before processing the next file'
+                        time.sleep(3)
                 else:
                     print 'error: committing %s failed: %s' % \
-                            (file, response['edit']['result'])
+                            (filename, response['edit']['result'])

Benjamin Mako Hill || Want to submit a patch?